feat: Disabled datasource selector in query pages#36940
feat: Disabled datasource selector in query pages#36940albinAppsmith merged 9 commits intoreleasefrom
Conversation
github-actions
bot
added
IDE Navigation
|
/build-deploy-preview skip-test=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11383749752. |
📝 WalkthroughWalkthroughThe pull request introduces a new feature flag, Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (2)
app/client/src/pages/Editor/QueryEditor/QueryEditorHeader.tsx (1)
75-77: Approve changes with a minor suggestion for naming clarity.The introduction of the feature flag is well-implemented. However, consider renaming the constant to
isDatasourceSelectorEnabledfor better clarity, as the current name might be misleading.-const isDatasourceSelectorDisabled = useFeatureFlag( +const isDatasourceSelectorEnabled = useFeatureFlag( FEATURE_FLAG.release_ide_datasource_selector_enabled, );app/client/src/ce/entities/FeatureFlag.ts (1)
42-43: LGTM. Consider adding a comment for the new feature flag.The addition of the
release_ide_datasource_selector_enabledflag is consistent with the existing structure and naming conventions. Good job on setting the default value tofalse, which aligns with the feature flag best practices.Consider adding a brief comment above the new flag in the
FEATURE_FLAGobject to describe its purpose. This would improve maintainability and help other developers understand the flag's intended use.+ // Controls the visibility of the datasource selector in the query editor release_ide_datasource_selector_enabled: "release_ide_datasource_selector_enabled",Also applies to: 79-79
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
- app/client/src/ce/entities/FeatureFlag.ts (2 hunks)
- app/client/src/pages/Editor/QueryEditor/QueryEditorHeader.tsx (2 hunks)
🧰 Additional context used
|
Deploy-Preview-URL: https://ce-36940.dp.appsmith.com |
…o action-redesign/remove-datasource-selector
albinAppsmith
requested review from
ApekshaBhosale and
sagar-qa007
as code owners
…o action-redesign/remove-datasource-selector
| @@ -1,5 +1,5 @@ | |||
| import { dataSources, agHelper } from "../../../../support/Objects/ObjectsCore"; | |||
| describe( | |||
| describe.skip( | |||
There was a problem hiding this comment.
Any requirement to skip this case? Kindly share details. @albinAppsmith
There was a problem hiding this comment.
@sagar-qa007 we are putting this feature behind feature flag and later remove this. That's why the test is being skipped now and once I remove feature flag I will remove the file itself.
…o action-redesign/remove-datasource-selector
…o action-redesign/remove-datasource-selector
|
/build-deploy-preview skip-test=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11512276526. |
|
Deploy-Preview-URL: https://ce-36940.dp.appsmith.com |
## Description This PR disable the datasource selector inside query editor. This change is behind feature flag to ensure that if this is needed, we can revert back using feature flag toggling. EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5382 Fixes appsmithorg#35534 ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11512255262> > Commit: ccdb522 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11512255262&attempt=3" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 25 Oct 2024 07:24:38 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new feature flag: `release_ide_datasource_selector_enabled`, allowing for future enhancements to the `DatasourceSelector` component. - Conditional rendering of the `DatasourceSelector` in the `QueryEditorHeader` based on the new feature flag. - **Bug Fixes** - Disabled the test suite for the "Switch datasource" functionality as it is currently under a feature flag. These changes enhance the flexibility of the application and improve the user experience by controlling the visibility of features based on their activation status. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
3 participants
Description
This PR disable the datasource selector inside query editor. This change is behind feature flag to ensure that if this is needed, we can revert back using feature flag toggling.
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/5382
Fixes #35534
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11512255262
Commit: ccdb522
Cypress dashboard.
Tags:
@tag.AllSpec:
Fri, 25 Oct 2024 07:24:38 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
release_ide_datasource_selector_enabled, allowing for future enhancements to theDatasourceSelectorcomponent.DatasourceSelectorin theQueryEditorHeaderbased on the new feature flag.Bug Fixes
These changes enhance the flexibility of the application and improve the user experience by controlling the visibility of features based on their activation status.