-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: external merge request from Contributor #36925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
rahulbarwal
wants to merge
20
commits into
release
from
external-contri/fix/button-tooltip-in-table_widgetV2
Closed
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9b27dfc
fix:- added elipsis and tooltip to the button content in table widget…
skjameela b1ebb20
Merge remote-tracking branch 'contributor-fork/fix/button-tooltip-in-…
rahulbarwal 48d92df
resolved review comments
skjameela 92a26c9
resolved review comments for button tooltip
skjameela f35baf7
Merge branch 'fix/button-tooltip-in-table_widgetV2' of https://github…
rahulbarwal dd9b0b4
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal 8ffde6e
resolved the prettier and linting issues
skjameela f1be30b
Merge branch 'fix/button-tooltip-in-table_widgetV2' of https://github…
rahulbarwal 39d624e
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal 8f9d8d8
resolved review comments and added test cases
skjameela 4798350
removed duplicate test cases
skjameela fa303f9
Resolved merge conflict in AutoTooltipComponent.test.tsx
skjameela 7afdc68
Merge branch 'fix/button-tooltip-in-table_widgetV2' of https://github…
rahulbarwal cd9a5b0
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal af3c8c4
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal 36bfa53
resolved linting and prettier issues
skjameela 79e485c
Merge branch 'fix/button-tooltip-in-table_widgetV2' of https://github…
rahulbarwal 0f11e80
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal 6696227
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal 44de49c
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check for null
spanElementbefore accessing propertiesIf
spanElementis null, accessing its properties will cause an error.Apply this diff to handle the null case:
function isButtonTextTruncated(element: HTMLElement) { const spanElement = element.querySelector("span"); + if (!spanElement) return false; const offsetWidth = spanElement.offsetWidth; const scrollWidth = spanElement.scrollWidth; return scrollWidth > offsetWidth; }📝 Committable suggestion