chore: Add custom tag for pg build in ad-hoc image builder#36913
Merged
chore: Add custom tag for pg build in ad-hoc image builder#36913
Conversation
trishaanand
approved these changes
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR to add support for custom pg image during the ad-hoc-builder script. Procedure for the hotfixes from v1.45 is as follows:
Steps to perform the hotfix:
hotfix/<version>and note down the commit-shapg-hotfix/<version>from commit sha onpgbranch from step 1./build.sh -DskipTestswithin server directory to avoid any build failures at later stages on both the hotfix branches@db-infrateam as requiredpg-hotfix/<version>branch to generatepgspecific tagpg-vx.y.zpg-vx.y.ztag from step 4, run the ad-hoc image builder withhotfix/<version>branch to generate specific tagvx.y.zand pass thepg_tagcreated in step 4 i.e.pg-vx.y.zvx.y.zvx.y.zas this is not supported in the ad-hoc image generation script. Make sure to have support for platforms:linux/arm64,linux/amd64Fixes #36838
/test Sanity
🔍 Cypress test results
Warning
Tests have not run on the HEAD 9af256c yet
Wed, 16 Oct 2024 13:05:17 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?