fix: inline editing test case in TableV2 by rahulbarwal · Pull Request #36697 · appsmithorg/appsmith

rahulbarwal · 2024-10-04T06:17:10Z

Description

This pull request fixes the inline editing test case in TableV2.
The test case was failing due to an incorrect assertion, so this commit updates the assertion to match the expected result.

Additionally, the limited-tests.txt file is updated to include the TableV2 inline editing test case.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Table"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11210291429
Commit: ab03e73
Cypress dashboard.
Tags: @tag.Table
Spec:

Mon, 07 Oct 2024 08:00:59 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

The inline editing test case in TableV2 was failing due to an incorrect assertion. This commit fixes the test case by updating the assertion to match the expected result.

…case

coderabbitai · 2024-10-04T06:17:18Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

rahulbarwal · 2024-10-04T06:19:07Z

/ci-test-limit-count run_count=15

github-actions · 2024-10-04T06:19:38Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11175018536.
Cypress dashboard
PR: #36697.

abhvsn · 2024-10-04T08:58:38Z

/ci-test-limit-count run_count=15

github-actions · 2024-10-04T08:59:14Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11177061470.
Cypress dashboard
PR: #36697.

abhvsn · 2024-10-04T10:23:21Z

/ci-test-limit-count run_count=15

github-actions · 2024-10-04T10:23:53Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11178260654.
Cypress dashboard
PR: #36697.

github-actions · 2024-10-04T10:47:39Z

Failed server tests

com.appsmith.server.services.UserServiceWithDisabledSignupTest#createNewUserValidWhenDisabled
com.appsmith.server.services.UserServiceWithDisabledSignupTest#signUpViaFormLoginIfAlreadyInvited

github-actions · 2024-10-04T12:10:24Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11178260654.
Cypress dashboard url: Click here!
All Cypress tests have passed 🎉🎉🎉

***** Repeat Run Summary ***** Total Tests with repeat: 150 Total Passed: 142 Total Failed: 8 Total Skipped: 0 *****************************

rahulbarwal · 2024-10-07T05:19:29Z

/ci-test-limit

github-actions · 2024-10-07T05:20:01Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209160229.
Cypress dashboard
PR: #36697.

github-actions · 2024-10-07T05:43:31Z

Failed server tests

com.appsmith.server.services.UserServiceWithDisabledSignupTest#createNewUserValidWhenDisabled
com.appsmith.server.services.UserServiceWithDisabledSignupTest#signUpViaFormLoginIfAlreadyInvited

rahulbarwal · 2024-10-07T05:47:42Z

/ci-test-limit runId=11209160229

github-actions · 2024-10-07T05:48:14Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209442186.
Cypress dashboard
PR: #36697.

github-actions · 2024-10-07T05:57:43Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11209442186.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-10-07T06:12:41Z

Failed server tests

com.appsmith.server.services.UserServiceWithDisabledSignupTest#createNewUserValidWhenDisabled
com.appsmith.server.services.UserServiceWithDisabledSignupTest#signUpViaFormLoginIfAlreadyInvited

github-actions · 2024-10-07T06:12:52Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209707439.
Cypress dashboard
PR: #36697.

rahulbarwal · 2024-10-07T06:13:15Z

/ci-test-limit runId=11209160229

github-actions · 2024-10-07T06:13:44Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11209717871.
Cypress dashboard
PR: #36697.

github-actions · 2024-10-07T06:23:30Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11209717871.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-10-07T06:35:38Z

Failed server tests

com.appsmith.server.services.UserServiceWithDisabledSignupTest#createNewUserValidWhenDisabled
com.appsmith.server.services.UserServiceWithDisabledSignupTest#signUpViaFormLoginIfAlreadyInvited

rahulbarwal · 2024-10-07T06:45:29Z

/ci-test-limit-count run_count=15 runId=11209160229

github-actions · 2024-10-07T06:45:57Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11210109040.
Cypress dashboard
PR: #36697.

rahulbarwal · 2024-10-07T07:00:48Z

/ci-test-limit runId=11209160229

github-actions · 2024-10-07T07:01:20Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11210296368.
Cypress dashboard
PR: #36697.

github-actions · 2024-10-07T07:11:08Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11210296368.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

rahulbarwal · 2024-10-07T07:11:19Z

/ci-test-limit-count run_count=15 runId=11209160229

github-actions · 2024-10-07T07:11:52Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/11210453305.
Cypress dashboard
PR: #36697.

github-actions · 2024-10-07T07:25:33Z

Failed server tests

com.appsmith.server.services.ThemeServiceTest#cloneThemeToApplication_WhenSrcThemeIsSystemTheme_NoNewThemeCreated
com.appsmith.server.services.UserServiceWithDisabledSignupTest#createNewUserValidWhenDisabled
com.appsmith.server.services.UserServiceWithDisabledSignupTest#signUpViaFormLoginIfAlreadyInvited

rahulbarwal · 2024-10-07T08:31:16Z

Closing as we need to merge to release.
New PR: #36721

github-actions · 2024-10-07T08:38:03Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11210453305.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:
To know the list of identified flaky tests - Refer here

***** Repeat Run Summary ***** Total Tests with repeat: 150 Total Passed: 150 Total Failed: 0 Total Skipped: 0 *****************************

rahulbarwal added 2 commits October 4, 2024 11:45

fix: Update inline editing test case in TableV2

cd850ea

The inline editing test case in TableV2 was failing due to an incorrect assertion. This commit fixes the test case by updating the assertion to match the expected result.

fix: Update limited-tests.txt to include TableV2 inline editing test …

f55913c

…case

rahulbarwal added Widgets & Accelerators Pod Issues related to widgets & Accelerators ok-to-test Required label for CI labels Oct 4, 2024

rahulbarwal changed the title ~~Fix inline editing test case in TableV2~~ fix: inline editing test case in TableV2 Oct 4, 2024

Merge branch 'pg' into fix/pg-inline-editing-spec

b4ffe5f

chore: Add dummy commit

e1cb998

Fix inline editing test case to verify updated cell value

e00afb7

Fix inline editing test case to verify updated cell value

2763ced

Fix inline editing test case to verify updated cell value

78c8bf3

Removes sleep.

ab03e73

rahulbarwal changed the base branch from pg to release October 7, 2024 08:06

rahulbarwal changed the base branch from release to pg October 7, 2024 08:07

rahulbarwal closed this Oct 7, 2024

Conversation

rahulbarwal commented Oct 4, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Oct 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

rahulbarwal commented Oct 4, 2024

Uh oh!

github-actions bot commented Oct 4, 2024

Uh oh!

abhvsn commented Oct 4, 2024

Uh oh!

github-actions bot commented Oct 4, 2024

Uh oh!

abhvsn commented Oct 4, 2024

Uh oh!

github-actions bot commented Oct 4, 2024

Uh oh!

github-actions bot commented Oct 4, 2024

Failed server tests

Uh oh!

github-actions bot commented Oct 4, 2024

Uh oh!

rahulbarwal commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Failed server tests

Uh oh!

rahulbarwal commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Failed server tests

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

rahulbarwal commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Failed server tests

Uh oh!

rahulbarwal commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

rahulbarwal commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

rahulbarwal commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Failed server tests

Uh oh!

rahulbarwal commented Oct 7, 2024

Uh oh!

github-actions bot commented Oct 7, 2024

Uh oh!

rahulbarwal commented Oct 4, 2024 •

edited by github-actions bot

Loading