Skip to content

chore: span push and sentry logs #36682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ApekshaBhosale merged 5 commits into from
Oct 7, 2024
Merged

chore: span push and sentry logs #36682

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d7d260
change
ApekshaBhosale Oct 3, 2024
2523206
login & signup error in params
ApekshaBhosale Oct 3, 2024
07a7d42
small change
ApekshaBhosale Oct 4, 2024
042a2ea
message change
ApekshaBhosale Oct 4, 2024
c93c9dc
removed unused code
ApekshaBhosale Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/client/src/ce/sagas/userSagas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ import type {
} from "reducers/uiReducers/usersReducer";
import { selectFeatureFlags } from "ee/selectors/featureFlagsSelectors";
import { getFromServerWhenNoPrefetchedResult } from "sagas/helper";

import * as Sentry from "@sentry/react";
import { Severity } from "@sentry/react";
export function* createUserSaga(
action: ReduxActionWithPromise<CreateUserRequest>,
) {
Expand Down Expand Up @@ -129,6 +130,12 @@ export function* createUserSaga(
error,
},
});
Sentry.captureException("Sign up failed", {
level: Severity.Error,
extra: {
error: error,
},
});
}
}

Expand Down
2 changes: 2 additions & 0 deletions ...ver/appsmith-interfaces/src/main/java/com/appsmith/external/constants/spans/BaseSpan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ public class BaseSpan {
public static final String GIT_SPAN_PREFIX = "git.";

public static final String APPLICATION_SPAN_PREFIX = "application.";

public static final String AUTHENTICATE = "authenticate";
Comment thread
ApekshaBhosale marked this conversation as resolved.

@nidhi-nair nidhi-nair Oct 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use more specific strings here? Just to make sure we know exactly what we're tracking?

@ApekshaBhosale ApekshaBhosale Oct 4, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have added general because i want to collect all authenticate related spans. tell me if all authenticate spans will be authenticate usernamepassword. this one we get with form login @nidhi-nair

@nidhi-nair nidhi-nair Oct 4, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, may be we'll know more as we gather data. Let's go ahead with this for now.

}
9 changes: 7 additions & 2 deletions ...erver/appsmith-server/src/main/java/com/appsmith/server/configurations/TracingConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@
import io.micrometer.observation.ObservationView;
import io.micrometer.tracing.Span;
import io.micrometer.tracing.exporter.SpanExportingPredicate;
import lombok.extern.slf4j.Slf4j;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
import org.springframework.http.server.reactive.observation.ServerRequestObservationContext;

import static com.appsmith.external.constants.spans.BaseSpan.APPSMITH_SPAN_PREFIX;
import static com.appsmith.external.constants.spans.BaseSpan.AUTHENTICATE;

/**
* This configuration file creates beans that are required to filter just Appsmith specific spans
*/
@Slf4j
@Configuration
public class TracingConfig {

Expand Down Expand Up @@ -45,8 +48,10 @@ ObservationPredicate noActuatorServerObservations() {
SpanExportingPredicate onlyAppsmithSpans() {
return (finishedSpan) -> {
if ((finishedSpan.getKind() != null && finishedSpan.getKind().equals(Span.Kind.SERVER))
|| finishedSpan.getName().startsWith(APPSMITH_SPAN_PREFIX)) {
// A span is either an http server request root or Appsmith specific
|| finishedSpan.getName().startsWith(APPSMITH_SPAN_PREFIX)
|| finishedSpan.getName().startsWith(AUTHENTICATE)
|| finishedSpan.getName().startsWith("authorize")) {
// A span is either an http server request root or Appsmith specific or login related or signup related
return true;
} else {
return false;
Expand Down