Skip to content

fix: fixed mysql plugin tests by closing the connections #36657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NilanshBansal merged 5 commits into from
Oct 2, 2024
Merged

fix: fixed mysql plugin tests by closing the connections #36657

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5f4f72f
fixed mysql plugin tests by increasing the max connections
NilanshBansal Oct 2, 2024
07fd247
closed connections after each test
NilanshBansal Oct 2, 2024
15d3509
minor change
NilanshBansal Oct 2, 2024
25da840
Update app/server/appsmith-plugins/mysqlPlugin/src/test/java/com/exte…
NilanshBansal Oct 2, 2024
3b9f579
addressed review comments
NilanshBansal Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...rver/appsmith-plugins/mysqlPlugin/src/test/java/com/external/plugins/MySqlPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,13 @@ public class MySqlPluginTest {
@SuppressWarnings("rawtypes") // The type parameter for the container type is just itself and is
// pseudo-optional.
@Container
public static MySQLContainer mySQLContainer = new MySQLContainer(
public static MySQLContainer mySQLContainer = (MySQLContainer) new MySQLContainer(
DockerImageName.parse("mysql/mysql-server:8.0.25").asCompatibleSubstituteFor("mysql"))
.withUsername("mysql")
.withPassword("password")
.withDatabaseName("test_db");
.withDatabaseName("test_db")
// Increased max connections to 400 to support the increased max connection pool size
.withCommand("--max_connections=400");
Comment thread
NilanshBansal marked this conversation as resolved.
Outdated

@SuppressWarnings("rawtypes") // The type parameter for the container type is just itself and is
// pseudo-optional.
Expand Down
2 changes: 1 addition & 1 deletion ...a/com/appsmith/server/connectionpoolconfig/configurations/ConnectionPoolConfigCETest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class ConnectionPoolConfigCETest {
@Test
public void verifyGetMaxConnectionPoolSizeProvidesDefaultValue() {
// this is same as default
Integer connectionPoolMaxSize = 20;
Integer connectionPoolMaxSize = 5;
Comment thread
NilanshBansal marked this conversation as resolved.

Mono<Integer> connectionPoolMaxSizeMono = connectionPoolConfig.getMaxConnectionPoolSize();
StepVerifier.create(connectionPoolMaxSizeMono).assertNext(poolSize -> {
Expand Down