Skip to content

chore: fetch spec with removed third party #36636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sagar-qa007 merged 9 commits into from
Oct 3, 2024
Merged

chore: fetch spec with removed third party #36636

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4b38812
Updated fetch spec
sagar-qa007 Oct 1, 2024
38b475b
prettier update
sagar-qa007 Oct 1, 2024
7180da3
Adding a line
sagar-qa007 Oct 2, 2024
0ab5d31
reverted changes for prettier
sagar-qa007 Oct 2, 2024
20018d4
Updated spec with retry
sagar-qa007 Oct 3, 2024
a49d01f
updated flow to remove flakyness
sagar-qa007 Oct 3, 2024
d71687c
Run api
sagar-qa007 Oct 3, 2024
c9a584a
reverted the change
sagar-qa007 Oct 3, 2024
3a3ab54
removed comment
sagar-qa007 Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions app/client/cypress/e2e/Regression/ServerSide/JsFunctionExecution/Fetch_Spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import {
agHelper,
apiPage,
dataManager,
entityExplorer,
jsEditor,
propPane,
Expand Down Expand Up @@ -76,18 +78,25 @@ describe("Tests fetch calls", { tags: ["@tag.JS"] }, () => {
});

it("3. Tests if fetch works with store value", function () {
apiPage.CreateAndFillApi(
dataManager.dsValues[dataManager.defaultEnviorment].mockGenderAge +
`{{this.params.person}}`,
"Gender_Age",
);
apiPage.RunAPI();
entityExplorer.DragDropWidgetNVerify("buttonwidget", 500, 200);
EditorNavigation.SelectEntityByName("Button1", EntityType.Widget);
propPane.TypeTextIntoField("Label", "getUserID");
propPane.TypeTextIntoField("Label", "getUserName");
propPane.EnterJSContext(
"onClick",
`{{fetch('https://jsonplaceholder.typicode.com/todos/1')
.then(res => res.json())
.then(json => storeValue('userId', json.userId))
.then(() => showAlert("UserId: " + appsmith.store.userId))}}`,
`{{(async function(){
const gender = await Gender_Age.run({ person: "sagar" });
storeValue("Gender", gender);
showAlert("Your name is " + appsmith.store.Gender.name);
})()}}`,
);
agHelper.Sleep(2000);
agHelper.ClickButton("getUserID");
agHelper.AssertContains("UserId: 1", "exist");

Copy link
Contributor

@coderabbitai coderabbitai bot Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Avoid using agHelper.Sleep(), utilize proper synchronization methods

Class, it's important to remember that using agHelper.Sleep() is discouraged in our testing code. Relying on arbitrary sleep durations can lead to flaky tests and inefficient execution.

Please consider removing agHelper.Sleep(2000); and instead use Cypress's built-in commands for synchronization. For instance, you can use cy.wait() with aliases to wait for specific network calls or cy.get() to wait for elements to appear before interacting with them.

agHelper.ClickButton("getUserName");
agHelper.AssertContains("Your name is sagar", "exist");
});
});