Skip to content

fix: updated the max connection pool size and datasourceDestroy method #36631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NilanshBansal merged 2 commits into from
Oct 2, 2024
Merged

fix: updated the max connection pool size and datasourceDestroy method #36631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6853ee
updated the max connection pool size and datasourceDestroy method for…
NilanshBansal Oct 1, 2024
04617ce
updated test
NilanshBansal Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,12 +692,11 @@ public void datasourceDestroy(ConnectionContext<ConnectionPool> connectionContex
*/
sshTunnelContext.getServerSocket().close();
sshTunnelContext.getSshClient().disconnect();
sshTunnelContext.getThread().stop();
sshTunnelContext.getThread().interrupt(); // Gracefully interrupt the thread
} catch (IOException e) {
log.error("Failed to destroy SSH tunnel context: " + e.getMessage());
}
}

return Mono.empty();
})
.subscribeOn(scheduler)
Expand Down
2 changes: 1 addition & 1 deletion ...r/appsmith-plugins/mysqlPlugin/src/main/java/com/external/utils/MySqlDatasourceUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

public class MySqlDatasourceUtils {

public static int MAX_CONNECTION_POOL_SIZE = 5;
public static int MAX_CONNECTION_POOL_SIZE = 20;

/**
* 1 sec is the recommended value as shown in the example here:
Expand Down
2 changes: 1 addition & 1 deletion ...a/com/appsmith/server/connectionpoolconfig/configurations/ConnectionPoolConfigCETest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class ConnectionPoolConfigCETest {
@Test
public void verifyGetMaxConnectionPoolSizeProvidesDefaultValue() {
// this is same as default
Integer connectionPoolMaxSize = 5;
Integer connectionPoolMaxSize = 20;

Mono<Integer> connectionPoolMaxSizeMono = connectionPoolConfig.getMaxConnectionPoolSize();
StepVerifier.create(connectionPoolMaxSizeMono).assertNext(poolSize -> {
Expand Down