Skip to content

fix: remove cache control headers for requests handled with an error in Caddy #36590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvj1988 merged 2 commits into from
Oct 7, 2024
+8 −3
Merged

fix: remove cache control headers for requests handled with an error in Caddy #36590

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1a69b8
fix: Add cache control headers only for successful requests
Sep 27, 2024
0f87242
Remove Cache-Control handle_errors block and replace skip_log with lo…
Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions deploy/docker/fs/opt/appsmith/caddy-reconfigure.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ parts.push(`
}

# skip logs for health check
skip_log /api/v1/health
log_skip /api/v1/health

# skip logs for sourcemap files
@source-map-files {
path_regexp ^.*\.(js|css)\.map$
}
skip_log @source-map-files
log_skip @source-map-files

# The internal request ID header should never be accepted from an incoming request.
request_header -X-Appsmith-Request-Id
Expand Down Expand Up @@ -154,7 +154,12 @@ parts.push(`

handle_errors {
respond "{err.status_code} {err.status_text}" {err.status_code}
header -Server
header {
# Remove the Server header from the response.
-Server
# Remove Cache-Control header from the response.
-Cache-Control
}
}
}

Expand Down