Skip to content

fix: Query instance failure caused by missing prepared statement obj #36493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albinAppsmith merged 2 commits into from
Sep 24, 2024
Merged

fix: Query instance failure caused by missing prepared statement obj #36493

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37776ef
fix: Query instance failure caused by missing prepared statement obj
albinAppsmith Sep 24, 2024
420801e
fix: made plugin config obj optional
albinAppsmith Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions app/client/src/pages/Editor/QueryEditor/QueryResponseTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,14 @@ const QueryResponseTab = (props: Props) => {
hintMessages = actionResponse.messages;
}

const { pluginSpecifiedTemplates } =
currentActionConfig.actionConfiguration;
const { actionConfiguration } = currentActionConfig;
const hasPluginSpecifiedTemplates =
actionConfiguration?.pluginSpecifiedTemplates?.[0]?.value === true;
// oracle have different key for prepared statements
const hasPreparedStatement =
actionConfiguration?.formData?.preparedStatement?.data === true;
Comment on lines +208 to +210
Copy link
Member

@mohanarpit mohanarpit Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albinAppsmith Why is Oracle plugin different from other plugins in this regard?

Copy link
Contributor Author

@albinAppsmith albinAppsmith Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmanAgarwal041 Can you help here with the reasoning behind this?
@mohanarpit I have already created an issue for tracking this.
#36495

Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albinAppsmith I am not really sure about this, why is this different. Will have to check

Copy link
Contributor Author

@albinAppsmith albinAppsmith Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AmanAgarwal041 any update on this?


if (
error &&
pluginSpecifiedTemplates &&
pluginSpecifiedTemplates.length > 0 &&
pluginSpecifiedTemplates[0].value === true
) {
if (error && (hasPluginSpecifiedTemplates || hasPreparedStatement)) {
showPreparedStatementWarning = true;
}
}
Expand Down