-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: batched evaluate action params to a chunk size #36482
Conversation
WalkthroughThe changes introduce a new constant, Changes
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/11147450574. |
Deploy-Preview-URL: https://ce-36482.dp.appsmith.com |
Merging this as the planned unit test which blocked this didn't help in asserting the call stack issue. |
Description
In this PR, we fix the payload evaluation issue by adding a batching mechanism.
Root cause the issue here was that using yield call in loop tends to call stack overflow which is a known open issue in the redux-saga library. The popular workaround to this is to add
yield delay(0
after n number of batch.Fixes #36383
Automation
/test all
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11134117696
Commit: a3a583f
Cypress dashboard.
Tags:
@tag.All
Spec:
Wed, 02 Oct 2024 01:49:36 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit