Skip to content

fix: show bindings menu does not appear in split mode #36378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KelvinOm merged 5 commits into from
Sep 20, 2024
Merged

fix: show bindings menu does not appear in split mode #36378

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
17bc64f
Fix show binding menu does not appear in split view
a6hishekpandey Sep 17, 2024
39108a7
Merge branch 'appsmithorg:release' into fix/35775-show-bindings-menu-…
a6hishekpandey Sep 17, 2024
aed9950
Merge branch 'appsmithorg:release' into fix/35775-show-bindings-menu-…
a6hishekpandey Sep 18, 2024
22689dd
Address prettier's style issues
a6hishekpandey Sep 18, 2024
093ffed
Merge branch 'release' into fix/35775-show-bindings-menu-does-not-app…
a6hishekpandey Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/client/src/pages/Editor/Explorer/Entity/EntityProperties.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import { Button } from "@appsmith/ads";
import { getEntityProperties } from "ee/pages/Editor/Explorer/Entity/getEntityProperties";
import store from "store";
import { ENTITY_TYPE } from "entities/DataTree/dataTreeFactory";
import { getIDEViewMode } from "selectors/ideSelectors";
import { EditorViewMode } from "ee/entities/IDE/constants";
import { DEFAULT_EXPLORER_PANE_WIDTH } from "constants/AppConstants";
import { BOTTOM_BAR_HEIGHT } from "components/BottomBar/constants";

Expand Down Expand Up @@ -44,6 +46,8 @@ export function EntityProperties() {
(state: AppState) => state.ui.widgetDragResize.lastSelectedWidget,
);

const ideViewMode = useSelector(getIDEViewMode);

useEffect(() => {
document.addEventListener("click", handleOutsideClick);

Expand Down Expand Up @@ -123,7 +127,10 @@ export function EntityProperties() {
ref.current.style.bottom = "unset";
}

ref.current.style.left = DEFAULT_EXPLORER_PANE_WIDTH + "px";
ref.current.style.left =
Copy link
Contributor

@alex-golovanov alex-golovanov Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should manipulate the DOM directly in this scenario and normally I would request for a refactor of such. However, given that this is working fix from an external contributor and it would be too much to ask to fix our mess, I'll approve this PR and create a separate issue to refactor this component later.

Copy link
Contributor Author

@a6hishekpandey a6hishekpandey Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-golovanov okay, thankyou.

ideViewMode === EditorViewMode.SplitScreen
? "100%"
: DEFAULT_EXPLORER_PANE_WIDTH + "px";
}
}, [entityId]);

Expand Down