-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore: Map Chart Spec #36343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
chore: Map Chart Spec #36343
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bda8441
Trigger Build
487239b
update mapchart
ed9525f
add test to limited list
fff28ea
remove only
d986178
remove genreated snaps
0d3b331
fix prettier error
6922c69
update selector
0a1afd3
update selector
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,13 +14,13 @@ import EditorNavigation, { | |
|
|
||
| const _mapChartCaption = "text:last-child"; | ||
| const _mapChartPlot = (text: string) => | ||
| "//text()[contains(., '" + text + "')]/.."; | ||
| `//*[name()='svg']//*[name()='text' and contains(text(), '${text}')]`; | ||
|
|
||
| describe( | ||
| "Map Chart Widget Functionality", | ||
| { tags: ["@tag.Widget", "@tag.Maps", "@tag.Visual"] }, | ||
| function () { | ||
| it("1. Drag and drop a Map Chart widget and verify", function () { | ||
| it.only("1. Drag and drop a Map Chart widget and verify", function () { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please remove
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. |
||
| entityExplorer.DragDropWidgetNVerify(draggableWidgets.MAPCHART, 200, 200); | ||
| deployMode.DeployApp( | ||
| locators._widgetInDeployed(draggableWidgets.MAPCHART), | ||
|
|
@@ -135,18 +135,17 @@ describe( | |
| it("4. Verify General settings", function () { | ||
| // update the title and verify | ||
| propPane.TypeTextIntoField("Title", "App Sign Up"); | ||
| agHelper.AssertText(_mapChartCaption, "text", "App Sign Up"); | ||
| deployMode.DeployApp( | ||
| locators._widgetInDeployed(draggableWidgets.MAPCHART), | ||
| ); | ||
| agHelper.AssertText(_mapChartCaption, "text", "App Sign Up"); | ||
| agHelper.VerifySnapshot(locators._root, "mapwithcustomtitle"); | ||
| deployMode.NavigateBacktoEditor(); | ||
| EditorNavigation.SelectEntityByName("MapChart1", EntityType.Widget); | ||
|
|
||
| // update the visibility using toggle and verify | ||
| propPane.TogglePropertyState("Visible", "Off"); | ||
| deployMode.DeployApp(); | ||
| agHelper.AssertElementAbsence( | ||
| deployMode.DeployApp( | ||
| locators._widgetInDeployed(draggableWidgets.MAPCHART), | ||
| ); | ||
| agHelper.VerifySnapshot(locators._root, "mapwithvisibilityoff"); | ||
|
|
@@ -158,9 +157,6 @@ describe( | |
| deployMode.DeployApp( | ||
| locators._widgetInDeployed(draggableWidgets.MAPCHART), | ||
| ); | ||
| agHelper.AssertElementVisibility( | ||
| locators._widgetInDeployed(draggableWidgets.MAPCHART), | ||
| ); | ||
| agHelper.VerifySnapshot(locators._root, "mapwithvisibilityon"); | ||
| deployMode.NavigateBacktoEditor(); | ||
| EditorNavigation.SelectEntityByName("MapChart1", EntityType.Widget); | ||
|
|
@@ -184,20 +180,20 @@ describe( | |
| EditorNavigation.SelectEntityByName("MapChart1", EntityType.Widget); | ||
| }); | ||
|
|
||
| it("5. Update onDataPointClick and Verify", function () { | ||
| it.only("5. Update onDataPointClick and Verify", function () { | ||
| // Create the Alert Modal and verify Modal name | ||
| propPane.SelectPropertiesDropDown("Map type", "Asia"); | ||
| propPane.SelectPlatformFunction("onDataPointClick", "Show alert"); | ||
| agHelper.TypeText( | ||
| propPane._actionSelectorFieldByLabel("Message"), | ||
| "Data Point {{MapChart1.selectedDataPoint.label}} Clicked", | ||
| ); | ||
| agHelper.GetNClick(propPane._actionSelectorPopupClose); | ||
|
|
||
| deployMode.DeployApp( | ||
| locators._widgetInDeployed(draggableWidgets.MAPCHART), | ||
| ); | ||
| agHelper.GetNClick(_mapChartPlot("RU: 1.30"), 0, true); | ||
| agHelper.ValidateToastMessage("Data Point Russian Federation Clicked"); | ||
| agHelper.GetNClick(_mapChartPlot("IN: 2"), 0); | ||
| agHelper.ValidateToastMessage("Data Point India Clicked"); | ||
| deployMode.NavigateBacktoEditor(); | ||
| EditorNavigation.SelectEntityByName("MapChart1", EntityType.Widget); | ||
|
|
||
|
|
@@ -206,11 +202,11 @@ describe( | |
| "onDataPointClick", | ||
| "{{showAlert('Converted to Js and clicked '+ MapChart1.selectedDataPoint.label)}}", | ||
| ); | ||
| agHelper.GetNClick(_mapChartPlot("IN: 2"), 0); | ||
| agHelper.ValidateToastMessage("Converted to Js and clicked India"); | ||
| deployMode.DeployApp( | ||
| locators._widgetInDeployed(draggableWidgets.MAPCHART), | ||
| ); | ||
| agHelper.GetNClick(_mapChartPlot("CN: .40"), 0, true); | ||
| agHelper.ValidateToastMessage("Converted to Js and clicked China"); | ||
| deployMode.NavigateBacktoEditor(); | ||
| EditorNavigation.SelectEntityByName("MapChart1", EntityType.Widget); | ||
| }); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+54.2 KB
...s/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts/mapchartsimple.snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+60.5 KB
...egression/ClientSide/Widgets/Others/MapChart_Spec.ts/mapwithantarctica.snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+68.6 KB
...ts/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts/mapwitheurope.snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+40.2 KB
...ression/ClientSide/Widgets/Others/MapChart_Spec.ts/mapwithnorthamerica.snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+36 KB
...ression/ClientSide/Widgets/Others/MapChart_Spec.ts/mapwithsouthamerica.snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+8.48 KB
...ots/Regression/ClientSide/Widgets/Others/MapChart_Spec.ts/mapwithworld.snap.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please use data-testid or css locator here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. The rendered component is coming from 3rd library. Not much control over it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's optimise this then. Discussing with you offline.