Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
393a060
Initial module setup
hetunandu Sep 6, 2024
b3fae4f
Merge branch 'release' into chore/plugin-action-editor
hetunandu Sep 9, 2024
04d8475
Merge branch 'release' into chore/plugin-action-editor
hetunandu Sep 9, 2024
f1cd097
Figure out usage
hetunandu Sep 9, 2024
fe2cda8
Remove ee files
hetunandu Sep 9, 2024
b4b98eb
Merge branch 'refs/heads/release' into chore/move-toolbar-to-ide
hetunandu Sep 9, 2024
783744f
move the toolbar
hetunandu Sep 9, 2024
56e9bb5
Merge branch 'release' into chore/move-toolbar-to-ide
hetunandu Sep 10, 2024
1fd1f61
remove old implementation
hetunandu Sep 10, 2024
f32b633
improve separation
hetunandu Sep 10, 2024
29d59fd
update to use ide modular approach
hetunandu Sep 10, 2024
0862673
Merge branch 'release' into chore/plugin-action-editor-1
hetunandu Sep 11, 2024
d9b5630
Convert to Module Callout
hetunandu Sep 11, 2024
976b8a1
CTA to convert to module
hetunandu Sep 11, 2024
27c09af
Merge branch 'release' into chore/plugin-action-editor-1
hetunandu Sep 12, 2024
8d6b9ec
Merge branch 'release' into chore/plugin-action-editor-1
hetunandu Sep 12, 2024
f228288
Add disabled state
hetunandu Sep 12, 2024
1c58a00
fix imports
hetunandu Sep 12, 2024
0c050cb
implement run click
hetunandu Sep 13, 2024
7773e8e
Merge branch 'release' into chore/plugin-action-editor-1
hetunandu Sep 13, 2024
8d0eab2
fix lint issue
hetunandu Sep 13, 2024
1f40848
missed fix
hetunandu Sep 13, 2024
066f32f
Merge branch 'chore/plugin-action-editor-1' into chore/plugin-action-…
hetunandu Sep 13, 2024
1cfc8bf
add other app menu options
hetunandu Sep 13, 2024
4727ae0
Merge branch 'release' into chore/plugin-action-editor-2
hetunandu Sep 13, 2024
708701c
clean up
hetunandu Sep 13, 2024
39aea09
remove merge markers
hetunandu Sep 16, 2024
62c99ba
chore: Implement useIsEditorInitialised hook
hetunandu Sep 16, 2024
330560e
Merge branch 'release' into chore/use-editor-initialised-hook
hetunandu Sep 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/client/src/IDE/hooks/index.ts
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
export { useIsInSideBySideEditor } from "./useIsInSideBySideEditor";
export { useIsEditorInitialised } from "ee/IDE/hooks/useIsEditorInitialised";
4 changes: 2 additions & 2 deletions app/client/src/PluginActionEditor/PluginActionEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import {
import { PluginActionContextProvider } from "./PluginActionContext";
import { get } from "lodash";
import EntityNotFoundPane from "pages/Editor/EntityNotFoundPane";
import { getIsEditorInitialized } from "selectors/editorSelectors";
import Spinner from "components/editorComponents/Spinner";
import CenteredWrapper from "components/designSystems/appsmith/CenteredWrapper";
import { Text } from "@appsmith/ads";
import { useIsEditorInitialised } from "IDE/hooks";

interface ChildrenProps {
children: React.ReactNode | React.ReactNode[];
Expand All @@ -24,7 +24,7 @@ interface ChildrenProps {
const PluginActionEditor = (props: ChildrenProps) => {
const { pathname } = useLocation();

const isEditorInitialized = useSelector(getIsEditorInitialized);
const isEditorInitialized = useIsEditorInitialised();

const entity = identifyEntityFromPath(pathname);
const action = useSelector((state) => getActionByBaseId(state, entity.id));
Expand Down
8 changes: 8 additions & 0 deletions app/client/src/ce/IDE/hooks/useIsEditorInitialised.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { useSelector } from "react-redux";
import { getIsEditorInitialized } from "selectors/editorSelectors";

function useIsEditorInitialised() {
return useSelector(getIsEditorInitialized);
}

export { useIsEditorInitialised };
1 change: 1 addition & 0 deletions app/client/src/ee/IDE/hooks/useIsEditorInitialised.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { useIsEditorInitialised } from "ce/IDE/hooks/useIsEditorInitialised";