fix: consolidated api test file split to ce

[sneha122]

Description

Split ConsolidatedAPIServiceImplTest file to CE as we need to write modules related tests in EE.

EE Test PR: https://github.com/appsmithorg/appsmith-ee/pull/5140

Fixes #36276
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10872195570
Commit: fe51aaa
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Sun, 15 Sep 2024 15:46:52 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor

  • The package structure for the test class has been reorganized to better categorize services.

• Tests

  • Enhanced test functionality by incorporating additional service imports, potentially improving test coverage and functionality.

[coderabbitai]

Walkthrough

The changes involve a reorganization of the ConsolidatedAPIServiceImplTest.java file, which has been moved to a new package, com.appsmith.server.services.ce. Several import statements have been added to the file, indicating the inclusion of various services that may enhance the testing capabilities of the class. The core logic of the test class remains unchanged.

Changes

File	Change Summary
app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ConsolidatedAPIServiceImplTest.java	Package changed from com.appsmith.server.services to com.appsmith.server.services.ce; several import statements added for various services.

Assessment against linked issues

Objective	Addressed	Explanation
Add JUnit test case for PR #5125 (Task #36276)	✅

Suggested labels

Needs Triaging, IDE Product, ok-to-test

Poem

In the realm of code where tests reside,
A package moved, with services allied.
Imports added, the tests now expand,
In the land of Appsmith, improvements are planned!
With every change, the quality grows,
A brighter future, as everyone knows! 🌟

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ba6fd9b and fe51aaa.

Files selected for processing (1)

• app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ConsolidatedAPIServiceImplTest.java (2 hunks)

Additional comments not posted (5)

app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ConsolidatedAPIServiceImplTest.java (5)

1-1: Great work on reorganizing the package structure!

Moving the test class to the com.appsmith.server.services.ce package aligns well with the objective of splitting it into a Community Edition (CE) version. This change helps improve code organization and maintainability.

---

35-42: Nice job adding the necessary import statements!

The newly imported services seem relevant to the test class and will likely enhance its functionality and coverage. The additions are clean and do not introduce any issues.

---

Line range hint 80-88:

---

Line range hint 90-137:

---

Line range hint 139-587:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed server tests

• com.appsmith.server.imports.internal.ImportServiceTests#importApplicationInWorkspace_WhenCustomizedThemes_ThemesCreated

[github-actions]

Failed server tests

• com.appsmith.server.solutions.ce.ActionExecutionSolutionCETest#testActionExecuteSecondaryStaleConnection