chore: Running on failure only (reverting to original)

[sagar-qa007]

Description

Reverting to previous version as this steps specifically run for failure.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.ImportExport"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10848068018
Commit: d646576
Cypress dashboard.
Tags: @tag.ImportExport
Spec:

---

Fri, 13 Sep 2024 11:26:38 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Chores
  • Updated workflow conditions to trim Cypress log files only on job failures, improving log management for successful runs.

[coderabbitai]

Walkthrough

The pull request modifies the conditional execution of a step in the CI workflow file, specifically targeting the trimming of Cypress log files. The condition has been changed from if: always() to if: failure(), which means that the log-trimming step will now only execute if any previous step in the job has failed. This change enhances the control flow of the workflow.

Changes

File Path	Change Summary
.github/workflows/ci-test-limited-with-count.yml	Updated the condition for trimming Cypress log files from if: always() to if: failure().

Possibly related PRs

• chore: Return failure results #36233: This PR modifies the same workflow file, introducing a conditional check for test failures, which is related to the control flow adjustments made in the main PR.
• chore: Updated error handling #36288: This PR also affects the workflow file, enhancing error handling and logic for reporting CI test results, aligning with the changes regarding conditional execution based on test outcomes.

Suggested labels

Bug, ok-to-test

Poem

In the realm of code where workflows flow,
A tweak was made, now logs will show,
Only on failure, they’ll be trimmed with care,
Preserving success, for all to share.
A dance of logic, refined and neat,
In the CI world, this change is sweet! 🎉

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 31a0d0e and d646576.

Files selected for processing (1)

• .github/workflows/ci-test-limited-with-count.yml (1 hunks)

Additional comments not posted (1)

.github/workflows/ci-test-limited-with-count.yml (1)

365-365: Great work! The condition change looks good.

Updating the condition from always() to failure() will ensure that the log trimming step runs only when a previous step has failed. This is a nice optimization to preserve logs for successful runs in case they are needed for analysis later.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sagar-qa007]

@ApekshaBhosale I have added to always to check if logs comes and stored but it should only work if there is any failure. It is just a revert PR.