fix: Fix the issue for the reverse PR comment

[sagar-qa007]

Description

Fix the issue as flag value was interchange.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.ImportExport"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10846876122
Commit: aa17588
Cypress dashboard.
Tags: @tag.ImportExport
Spec:

---

Fri, 13 Sep 2024 10:01:50 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the logic for adding comments on pull requests based on CI test results, improving clarity of feedback.
  • Enhanced conditions for commenting on new CI failures and successful jobs to provide more accurate notifications.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifying the conditional logic for adding comments on pull requests based on the status of continuous integration (CI) tests. Specifically, the conditions for commenting when new CI failures occur and when the ci-test-limited job is successful have been inverted. This alteration affects how feedback is provided on pull requests, depending on the outcomes of the CI tests.

Changes

File Path	Change Summary
.github/workflows/build-client-server-count.yml	Inverted conditions for adding comments based on CI test results: comments for new CI failures and successful jobs have their logic reversed.

Possibly related PRs

• chore: Return failure results #36233: This PR modifies the GitHub Actions workflow to ensure that test failures are reported accurately, which is directly related to the changes in the main PR that also involve altering the logic for commenting on PRs based on CI test results.
• chore: Updated error handling #36288: This PR enhances error handling in the CI workflow, including modifications to the same workflow file as the main PR, indicating a direct connection in terms of CI test result handling and commenting logic.

Suggested labels

Bug, ok-to-test

Poem

In the realm of code where logic flows,
Comments once bright, now twist and pose.
CI's whispers, both new and old,
Share tales of tests, both brave and bold.
A dance of conditions, a curious sight,
Inverting the fate of feedback's light! 🌟

Tip

OpenAI O1 model for chat

• We have deployed OpenAI's latest O1 model for chat.
• OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model.
• Please share any feedback with us in the discussions post.

---

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ce02d3c and aa17588.

Files selected for processing (1)

• .github/workflows/build-client-server-count.yml (4 hunks)

Additional comments not posted (4)

.github/workflows/build-client-server-count.yml (4)

295-295: Please verify the intended behavior for adding comments on new CI failures.

The condition for adding a comment when there are new CI failures has been inverted. It now adds the comment when env.ci_test_failed is not 'true', which seems counterintuitive.

Please double-check if this change aligns with the intended behavior. If not, please revert the change to ensure comments are added correctly based on the CI test results.

---

309-309: Please verify the intended behavior for adding comments on successful CI tests.

The condition for adding a comment when the ci-test-limited job is successful has been inverted. It now adds the comment when env.ci_test_failed is 'true', which seems incorrect.

Please double-check if this change aligns with the intended behavior. If not, please revert the change to ensure comments are added correctly based on the CI test results.

---

454-454: Duplicate issue: Please refer to the previous comment on line 295.

This change is similar to the one made earlier in the file. It inverts the logic of when the comment is added based on the CI test results.

Please address this issue along with the previous comment to ensure consistent behavior for adding comments on new CI failures.

---

468-468: Duplicate issue: Please refer to the previous comment on line 309.

This change is similar to the one made earlier in the file. It inverts the logic of when the comment is added based on the CI test results.

Please address this issue along with the previous comment to ensure consistent behavior for adding comments on successful CI tests.

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.