Skip to content

test if only when adding a new widget do we compute the entire widget… #36293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vsvamsi1 wants to merge 3 commits into from
Closed

test if only when adding a new widget do we compute the entire widget… #36293

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcde7d1
test if only when adding a new widget do we compute the entire widget…
vsvamsi1 Sep 13, 2024
e572a11
test out remove excludeNodes
vsvamsi1 Sep 13, 2024
c8eb9f6
all paths are evaluated
vsvamsi1 Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/client/src/workers/common/DependencyMap/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
getAllPaths,
DataTreeDiffEvent,
getEntityNameAndPropertyPath,
isDynamicLeaf,
} from "ee/workers/Evaluation/evaluationUtils";
import type {
WidgetEntity,
Expand Down Expand Up @@ -148,6 +147,7 @@ export const updateDependencyMap = ({
const allAddedPaths = getAllPaths({
[fullPropertyPath]: get(unEvalDataTree, fullPropertyPath),
});

// If a new entity is added, add setter functions to all nodes
if (entityName === fullPropertyPath) {
const addedNodes = getEntitySetterFunctions(
Expand All @@ -164,7 +164,7 @@ export const updateDependencyMap = ({
didUpdateDependencyMap;

if (isWidgetActionOrJsObject(entity)) {
if (!isDynamicLeaf(unEvalDataTree, fullPropertyPath, configTree)) {
if (entityName === fullPropertyPath) {
Copy link
Contributor

@sagar-qa007 sagar-qa007 Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the failures and also kindly add/update unit test related to this file.

const entityDependencyMap = getEntityDependencies(
entity,
configTree[entityName],
Expand Down