fix: mongo uri spec flakiness#36249
Merged
AmanAgarwal041 merged 56 commits intoreleasefrom Sep 17, 2024
Merged
Conversation
added 28 commits
August 26, 2024 12:29
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10885288503. |
added 5 commits
September 16, 2024 23:13
Contributor
Author
|
/ci-test-limit-count run_count=20 |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10889253849. |
sagar-qa007
approved these changes
Sep 17, 2024
This was referenced Sep 17, 2024
Shivam-z
pushed a commit
to Shivam-z/appsmith
that referenced
this pull request
Sep 26, 2024
This was referenced Oct 1, 2024
This was referenced Nov 5, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were two things that were making this spec file act flaky:
ObjectId('id')but since the id was expected to be int, it was failing. So converting the default delete query generated from crud operation to{ _id: {{data_table.triggeredRow._id}}}actually started passing the whole of test.Fixes #35148
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10891454490
Commit: 3aef2d2
Cypress dashboard.
Tags:
@tag.DatasourceSpec:
Mon, 16 Sep 2024 21:03:05 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Chores