Skip to content

chore: Remove anvil from auto layout owners #36246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
znamenskii-ilia merged 1 commit into from
Sep 12, 2024
Merged

chore: Remove anvil from auto layout owners #36246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,18 @@ app/server/appsmith-server/src/test/java/com/appsmith/server/services/FeatureFla

# UI Builders Pod
app/client/generators/* @appsmithorg/anvil-team
app/client/src/actions/autoHeightActions.ts @appsmithorg/anvil-team
Copy link
Collaborator

@KelvinOm KelvinOm Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But someone has to own this, right? @riodeuno WDYT?

Copy link
Contributor

@riodeuno riodeuno Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KelvinOm Tagging @somangshu. The widgets pod can own this. This particular feature is related to Fixed mode, however, it is a core feature and not a widget feature. Owners of Widget Development API should own this.

app/client/src/actions/autoLayoutActions.ts @appsmithorg/anvil-team
app/client/src/actions/canvasSelectionActions.ts @appsmithorg/anvil-team
app/client/src/actions/reflowActions.ts @appsmithorg/anvil-team
app/client/src/actions/widgetSelectionActions.ts @appsmithorg/anvil-team
app/client/src/components/propertyControls/* @appsmithorg/anvil-team
app/client/src/layoutSystems/* @appsmithorg/anvil-team
app/client/src/layoutSystems/anvil/* @appsmithorg/anvil-team
app/client/src/pages/Editor/Canvas.tsx @appsmithorg/anvil-team
app/client/src/pages/Editor/CanvasLayoutConversion/* @appsmithorg/anvil-team
app/client/src/pages/Editor/PropertyPane/* @appsmithorg/anvil-team
app/client/src/pages/Editor/WidgetsEditor/* @appsmithorg/anvil-team
app/client/src/reducers/entityReducers/autoHeightReducers/* @appsmithorg/anvil-team
app/client/src/reducers/entityReducers/canvasWidgetsReducer.ts @appsmithorg/anvil-team
app/client/src/reflow/* @appsmithorg/anvil-team
app/client/src/sagas/AutoLayoutUpdateSagas.tsx @appsmithorg/anvil-team
app/client/src/sagas/CanvasSagas/* @appsmithorg/anvil-team
app/client/src/sagas/ReplaySaga.ts @appsmithorg/anvil-team
app/client/src/sagas/SnapshotSagas.ts @appsmithorg/anvil-team
Expand All @@ -78,14 +75,9 @@ app/client/src/sagas/WidgetOperationSagas.tsx @appsmithorg/anvil-team
app/client/src/sagas/WidgetOperationUtils.ts @appsmithorg/anvil-team
app/client/src/sagas/WidgetSelectUtils.ts @appsmithorg/anvil-team
app/client/src/sagas/WidgetSelectionSagas.ts @appsmithorg/anvil-team
app/client/src/sagas/autoHeightSagas/* @appsmithorg/anvil-team
app/client/src/sagas/layoutConversionSagas.ts @appsmithorg/anvil-team
app/client/src/selectors/autoHeightSelectors.ts @appsmithorg/anvil-team
app/client/src/selectors/autoLayoutSelectors.tsx @appsmithorg/anvil-team
app/client/src/selectors/canvasSelectors.ts @appsmithorg/anvil-team
app/client/src/selectors/widgetSelectors.ts @appsmithorg/anvil-team
app/client/src/utils/autoHeight/* @appsmithorg/anvil-team
app/client/src/utils/hooks/autoHeightUIHooks.ts @appsmithorg/anvil-team
app/client/src/utils/hooks/useAllowEditorDragToSelect.ts @appsmithorg/anvil-team
app/client/src/utils/hooks/useClickToSelectWidget.tsx @appsmithorg/anvil-team
app/client/src/utils/hooks/useDynamicAppLayout.tsx @appsmithorg/anvil-team
Expand Down