Skip to content

chore: add delete API call for rts#36186

Merged
abhvsn merged 1 commit intoreleasefrom
chore/add-delete-api-rts
Sep 9, 2024
Merged

chore: add delete API call for rts#36186
abhvsn merged 1 commit intoreleasefrom
chore/add-delete-api-rts

Conversation

@nsarupr
Copy link
Contributor

@nsarupr nsarupr commented Sep 9, 2024

Description

Add delete API for RTS

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features
    • Introduced a new method for sending HTTP DELETE requests, enhancing the app's ability to interact with web services effectively.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 9, 2024

Walkthrough

This pull request introduces a new method named delete in the RTSCaller class, enabling the sending of HTTP DELETE requests. The method accepts a String parameter representing the path and utilizes the existing makeRequest method to execute the request with the DELETE method type. This change expands the capabilities of the RTSCaller class for interacting with web services.

Changes

File Change Summary
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/RTSCaller.java Added public Mono<WebClient.RequestBodySpec> delete(@NonNull String path) method.

Possibly related PRs

Suggested labels

skip-changelog

Poem

In the realm of code, a new method's born,
With DELETE requests, the server's adorned.
RTSCaller now sends, with a swift little call,
Expanding its reach, it embraces them all.
A dance of the bytes, in harmony they play,
Enhancing our tools, in a seamless ballet! 🎉

Tip

New features

Walkthrough comment now includes:

  • Possibly related PRs: A list of potentially related PRs to help you recall past context.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs. You can also provide custom labeling instructions in the UI or configuration file.

Notes:

  • Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 9, 2024
@nsarupr nsarupr requested a review from abhvsn September 9, 2024 08:13
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/RTSCaller.java (1)

95-97: Well done on implementing the delete method.

The method delete correctly uses the existing makeRequest method to handle DELETE requests, which is a good practice to maintain consistency and reduce code duplication. The use of @NonNull is commendable as it ensures that the path parameter is not null, preventing potential null pointer exceptions.

However, it might be beneficial to consider adding some form of error handling or logging within the makeRequest method to ensure that any issues during the DELETE operation are properly managed and logged. This could improve the robustness of the API.

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1b16be8 and ea26d39.

Files selected for processing (1)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/helpers/RTSCaller.java (1 hunks)

@abhvsn abhvsn merged commit ea6b827 into release Sep 9, 2024
@abhvsn abhvsn deleted the chore/add-delete-api-rts branch September 9, 2024 11:06
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
## Description
> Add delete API for RTS


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags=""

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!CAUTION]  
> If you modify the content in this section, you are likely to disrupt
the CI result for your PR.

<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a new method for sending HTTP DELETE requests, enhancing
the app's ability to interact with web services effectively.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Co-authored-by: Nilesh Sarupriya <20905988+nsarupr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants