chore: Update test-build-docker-image.yml to trigger the build on pg branch#36135
chore: Update test-build-docker-image.yml to trigger the build on pg branch#36135
Conversation
WalkthroughThe changes to the GitHub Actions workflow configuration enhance the triggering conditions for pushes to include both the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub
participant CI/CD
participant Docker
Developer->>GitHub: Push to master or pg branch
GitHub->>CI/CD: Trigger workflow
CI/CD->>CI/CD: Run ci-test
CI/CD->>CI/CD: Run server-unit-tests
CI/CD->>CI/CD: Run client-unit-tests
CI/CD->>CI/CD: Prepare server artifacts
CI/CD->>Docker: Build Docker image with branch tag
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
.github/workflows/test-build-docker-image.yml (2)
103-103: Conditional Logic Update forci-testThe updated conditional logic to include the
pgbranch is appropriate and aligns with the PR's objectives. However, consider simplifying the condition to improve readability and maintainability.Consider refactoring the condition to a more readable format, perhaps by using a helper function or a YAML anchor to avoid repetition across jobs.
344-349: Missing Script:prepare_server_artifacts.shThe script
scripts/prepare_server_artifacts.sh, referenced in the GitHub Actions workflow, does not exist in the repository. This absence could lead to failures or incomplete execution of the workflow. Please ensure that the script is added to the repository and functions as intended.Analysis chain
Addition of
Place server artifacts-esJobThe new job to handle server artifacts is a welcome addition, potentially improving the workflow's efficiency in managing server-side components. Ensure that the script
prepare_server_artifacts.shexists and functions as expected.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence and functionality of the script. # Test: Check if the script exists. Expect: The script file should exist. if [[ -f scripts/prepare_server_artifacts.sh ]]; then echo "Script exists." else echo "Script does not exist." fiLength of output: 101
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/test-build-docker-image.yml (6 hunks)
Additional comments not posted (4)
.github/workflows/test-build-docker-image.yml (4)
24-26: Update to Trigger ConditionsThe changes to the trigger conditions for the
pushevent to include both themasterandpgbranches are well thought out. This ensures that the workflow is triggered for changes to either branch, aligning with the PR's objectives to enhance responsiveness and flexibility in the build process.
116-116: Updated Conditional Logic forserver-unit-testsThe inclusion of the
pgbranch in the conditional logic for theserver-unit-testsjob ensures that tests are run for changes to this branch, which is crucial for maintaining code quality across branches.
126-126: Conditional Logic Update forclient-unit-testsThe update to include the
pgbranch in the conditional logic for theclient-unit-testsjob is a prudent change, ensuring comprehensive testing across important branches.
371-371: Update to Docker Image TaggingThe modification to include the branch name dynamically in the Docker image tag is a smart move. It enhances the traceability and management of different builds from various branches.
| scripts/generate_info_json.sh | ||
| fi | ||
|
|
||
| - name: Place server artifacts-es |
There was a problem hiding this comment.
Why do we need this step?
There was a problem hiding this comment.
This is for placing the artifacts in required location. This won't have any effect in release branch though as the file itself is not present.
…branch (appsmithorg#36135) ## Description ## Summary by CodeRabbit - **New Features** - Expanded GitHub Actions workflow to trigger on both `master` and `pg` branches. - Introduced a new job for managing server artifacts. - **Improvements** - Enhanced workflow responsiveness to changes in multiple branches. - Updated Docker image tagging to dynamically include branch names for better versioning. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
Description
Summary by CodeRabbit
New Features
masterandpgbranches.Improvements