-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: allow multiple lines in alert component #36126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nerbos
merged 10 commits into
appsmithorg:release
from
saiprabhu-dandanayak:feat/allow-multiple-lines-in-alert
Sep 30, 2024
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
22a53c4
✨ feat: allow multiple lines in alert component
saiprabhu-dandanayak fc26810
formatted files
saiprabhu-dandanayak 03520b5
Merge branch 'release' of https://github.com/saiprabhu-dandanayak/app…
saiprabhu-dandanayak 1e5dde7
Merge branch 'release' of https://github.com/saiprabhu-dandanayak/app…
saiprabhu-dandanayak dff3b4c
fix:replaced ..ts with .ts for cypress file
saiprabhu-dandanayak 79e48f0
fix:removed cy.wait()
saiprabhu-dandanayak ea337a4
fix:removed in-line styling
saiprabhu-dandanayak 2ffb3bd
Merge branch 'release' of https://github.com/saiprabhu-dandanayak/app…
saiprabhu-dandanayak bcb5f6b
fix:lint & prettier issues
saiprabhu-dandanayak 82f488e
Merge branch 'release' of https://github.com/saiprabhu-dandanayak/app…
saiprabhu-dandanayak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletions
26
...ress/e2e/Regression/ClientSide/Widgets/Button/Button_showAlert_multiline_message_spec..ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { | ||
| draggableWidgets, | ||
| entityExplorer, | ||
| propPane, | ||
| agHelper, | ||
| } from "../../../../../support/Objects/ObjectsCore"; | ||
|
|
||
| describe( | ||
| "Tests for showAlert message with newline characters in the alert message", | ||
| { tags: ["@tag.Widget", "@tag.Button"] }, | ||
| () => { | ||
| before("Login to the app and navigate to the workspace", function () { | ||
| entityExplorer.DragDropWidgetNVerify(draggableWidgets.BUTTON); | ||
| }); | ||
|
|
||
| it("Verify showAlert message renders correctly with newline characters", () => { | ||
| propPane.EnterJSContext("onClick", "showAlert(`sai\n\nprabhu`)"); | ||
| agHelper.ClickButton("Submit"); | ||
| cy.wait(500); | ||
| cy.get(".Toastify", { timeout: 1000 }).should( | ||
| "have.text", | ||
| "sai\n\nprabhu", | ||
| ); | ||
| }); | ||
| }, | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.