Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updating the CSS to place the meatball icon in the correct place for Application Card #36112

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: Updating the CSS to place the meatball icon in the correct place for Application Card #36112

merged 1 commit into from
Sep 4, 2024

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented Sep 4, 2024 •
edited by github-actions bot
Loading

Description

Updating the CSS to place the meatball icon in the correct place for Application Card

Fixes #36084

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10697709457
Commit: 8750fd8
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Wed, 04 Sep 2024 08:41:00 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Enhanced the layout of the Card component's footer for a more balanced appearance.

  • Style

    • Introduced a new CSS property to improve spacing between elements in the CardFooter.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 4, 2024 •
edited
Loading

Walkthrough

The changes involve the addition of a CSS property to the CardFooter styled component in the Card.tsx file. This adjustment modifies the layout of the footer by applying justify-content: space-between;, which alters how child elements are spaced within the footer. The change aims to enhance the visual layout of the component.

Changes

File Change Summary
app/client/src/components/common/Card.tsx Added justify-content: space-between; to the CardFooter styled component.

Assessment against linked issues

Objective Addressed Explanation
The Meat ball icon for exporting the App on home page seems displaced (36084) ❌ The changes do not address the issue of icon displacement.

Poem

In the footer where cards reside,
Space is balanced, side by side.
With a touch of CSS flair,
Elements dance without a care.
A layout fresh, a sight to see,
Enhancing joy for you and me! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Platform Administration Pod Issues related to platform administration & management Production RBAC Product Issues, requests and enhancements around RBAC. labels Sep 4, 2024
@ankitakinger ankitakinger added the ok-to-test Required label for CI label Sep 4, 2024
coderabbitai[bot]
coderabbitai bot reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 420dc9b and 8750fd8.

Files selected for processing (1)
  • app/client/src/components/common/Card.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/components/common/Card.tsx

@ankitakinger ankitakinger merged commit 50bbc49 into release Sep 4, 2024
46 checks passed
@ankitakinger ankitakinger deleted the fix/meat-ball-icon-for-app branch September 4, 2024 08:52
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Sep 26, 2024
@ankitakinger @Shivam-z
fix: Updating the CSS to place the meatball icon in the correct place…
7eed496 
… for Application Card (appsmithorg#36112)

## Description

Updating the CSS to place the meatball icon in the correct place for
Application Card

Fixes [appsmithorg#36084 ](appsmithorg#36084)

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/10697709457>
> Commit: 8750fd8
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10697709457&attempt=2"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Wed, 04 Sep 2024 08:41:00 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Enhanced the layout of the Card component's footer for a more balanced
appearance.

- **Style**
- Introduced a new CSS property to improve spacing between elements in
the CardFooter.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ayushpahwa ayushpahwa ayushpahwa approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage ok-to-test Required label for CI Platform Administration Pod Issues related to platform administration & management Production RBAC Product Issues, requests and enhancements around RBAC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: The Meat ball icon for exporting the App on home page seems displaced when user has only view access
2 participants
@ankitakinger @ayushpahwa