Skip to content

chore: Enable netty metrics based on env var #36108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nidhi-nair merged 2 commits into from
Sep 4, 2024
Merged

chore: Enable netty metrics based on env var #36108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70494d9
chore: Enable netty metrics
nidhi-nair Sep 4, 2024
563db3a
chore: Enable netty metrics
nidhi-nair Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...server/appsmith-server/src/main/java/com/appsmith/server/configurations/CommonConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ public class CommonConfig {
@Value("${appsmith.micrometer.tracing.detail.enabled:false}")
private boolean tracingDetail;

@Value("${appsmith.micrometer.metrics.detail.enabled:false}")
private boolean metricsDetail;

private List<String> allowedDomains;

private String mongoDBVersion;
Expand Down
9 changes: 8 additions & 1 deletion ...th-server/src/main/java/com/appsmith/server/configurations/ReactorNettyConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,22 @@
package com.appsmith.server.configurations;

import lombok.RequiredArgsConstructor;
import org.springframework.boot.web.embedded.netty.NettyReactiveWebServerFactory;
import org.springframework.boot.web.server.WebServerFactoryCustomizer;
import org.springframework.stereotype.Component;

import java.util.function.Function;

@RequiredArgsConstructor
@Component
public class ReactorNettyConfiguration implements WebServerFactoryCustomizer<NettyReactiveWebServerFactory> {

private final CommonConfig commonConfig;

@Override
public void customize(NettyReactiveWebServerFactory factory) {
factory.addServerCustomizers(httpServer -> httpServer.metrics(true, Function.identity()));
if (commonConfig.isMetricsDetail()) {
factory.addServerCustomizers(httpServer -> httpServer.metrics(true, Function.identity()));
}
}
}
1 change: 1 addition & 0 deletions app/server/appsmith-server/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ appsmith.newrelic.micrometer.metrics.application.name=${APPSMITH_NEWRELIC_MICROM
spring.application.name=${OTEL_SERVICE_NAME:appsmith-anonymous}
appsmith.micrometer.metrics.enabled=${APPSMITH_MICROMETER_METRICS_ENABLED:false}
appsmith.micrometer.tracing.detail.enabled=${APPSMITH_ENABLE_TRACING_DETAIL:false}
appsmith.micrometer.metrics.detail.enabled=${APPSMITH_ENABLE_METRICS_DETAIL:false}

springdoc.api-docs.path=/v3/docs
springdoc.swagger-ui.path=/v3/swagger