-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: Allow table search to include label and value for tables with select column type #36061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jacquesikot
merged 10 commits into
release
from
feat/allow-label-search-in-table-widget
Sep 12, 2024
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4dc277e
complete fix
jacquesikot b608cf7
remove it.only from test cases
jacquesikot a8308c8
fix failing Select1_spec
jacquesikot fcf8a43
move test data to fixtures
jacquesikot 414ecaa
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
jacquesikot 8eec0ab
add implementation for different states of selectOptions
jacquesikot 5a8a8fb
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
jacquesikot a19af04
revert changes in Select1_spec
jacquesikot 5fe966d
add tests for JSON and JS options in property pane on table
jacquesikot f921efc
replace .t--property-control-options with _controlOption from commonl…
jacquesikot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| export const demoTableDataForSelect = ` | ||
| {{ | ||
| [ | ||
| { | ||
| role: 10, | ||
| id: 1, | ||
| name: "Alice Johnson", | ||
| email: "alice.johnson@example.com", | ||
| age: 28, | ||
| gender: 2 | ||
| }, | ||
| { | ||
| role: 20, | ||
| id: 2, | ||
| name: "Bob Smith", | ||
| email: "bob.smith@example.com", | ||
| age: 34, | ||
| gender: 1 | ||
| }, | ||
| { | ||
| role: 30, | ||
| id: 3, | ||
| name: "Charlie Brown", | ||
| email: "charlie.brown@example.com", | ||
| age: 25, | ||
| gender: 3 | ||
| }, | ||
| { | ||
| role: 20, | ||
| id: 4, | ||
| name: "Diana Prince", | ||
| email: "diana.prince@example.com", | ||
| age: 30, | ||
| gender: 2 | ||
| }, | ||
| { | ||
| role: 10, | ||
| id: 5, | ||
| name: "Evan Williams", | ||
| email: "evan.williams@example.com", | ||
| age: 27, | ||
| gender: 1 | ||
| } | ||
| ] | ||
| }} | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.