Skip to content

[Donot merge]: testing cypress flakiness #35874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AmanAgarwal041 wants to merge 27 commits into from
Closed

[Donot merge]: testing cypress flakiness #35874

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
276f28a
fix: added a limited test to check the failures
Aug 26, 2024
ac60ca5
fix: api multipart
Aug 26, 2024
0cb3558
fix: mysql 2 spec for checking the 12th index instead of 17
Aug 27, 2024
46349b5
fix: changed the page name to page1 from stores
Aug 27, 2024
c1d3112
fix: api multipart to use ted api
Aug 27, 2024
8a0bca2
fix: changing only the mysql2 spec and reverting other changes
Aug 28, 2024
69c8719
Merge branch 'release' of github.com:appsmithorg/appsmith into cypres…
Sep 2, 2024
8ed1298
Merge branch 'release' of github.com:appsmithorg/appsmith into cypres…
Sep 5, 2024
b84cf4f
fix: testing mongo spec fix
Sep 5, 2024
a246fd5
fix: testing mongo spec fix
Sep 6, 2024
8538c57
fix: testing mongo spec fix
Sep 6, 2024
7136122
fix: testing mongo spec fix
Sep 6, 2024
a83388a
fix: testing mongo spec fix
Sep 6, 2024
2319acf
fix: testing mongo spec fix
Sep 7, 2024
2bcac45
fix: testing mongo spec fix
Sep 9, 2024
aece969
fix: testing mongo spec fix
Sep 9, 2024
6aff87d
fix: testing mongo spec fix
Sep 9, 2024
e29d372
fix: testing mongo spec fix
Sep 10, 2024
506cec8
fix: testing mongo spec fix
Sep 10, 2024
2d381f2
fix: testing mongo spec fix
Sep 10, 2024
ae19c25
Merge branch 'release' of github.com:appsmithorg/appsmith into cypres…
Sep 10, 2024
85eb601
fix: testing mongo spec fix
Sep 10, 2024
02e7f62
Merge branch 'release' of github.com:appsmithorg/appsmith into cypres…
Sep 10, 2024
272d1b9
fix: testing mongo spec fix
Sep 10, 2024
f2587be
fix: testing mongo spec fix
Sep 10, 2024
4da52dc
fix: testing mongo spec fix
Sep 11, 2024
52703b2
fix: testing mongo spec fix
Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ describe(
updateNVerify(6, 4, newStoreSecret as string);
});

table.SelectTableRow(17, 0, true, "v2");
dataSources.AssertJSONFormHeader(17, 0, "store_id");
generateStoresSecretInfo(17);
table.SelectTableRow(12, 0, true, "v2");
dataSources.AssertJSONFormHeader(12, 0, "store_id");
generateStoresSecretInfo(12);
cy.get("@secretInfo").then(($secretInfo) => {
newStoreSecret = $secretInfo;
cy.log("newStoreSecret is : " + newStoreSecret);
updateNVerify(17, 4, newStoreSecret as string);
updateNVerify(12, 4, newStoreSecret as string);
});

//Hidden field bug - to add here aft secret codes are updated for some fields!
Expand Down
5 changes: 4 additions & 1 deletion app/client/cypress/limited-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# To run only limited tests - give the spec names in below format:
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
cypress/e2e/Regression/ServerSide/ApiTests/API_MultiPart_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/Mongo_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts

# For running all specs - uncomment below:
#cypress/e2e/**/**/*
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/support/Pages/ApiPage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ export class ApiPage {
| "RAW",
) {
this.agHelper.GetNClick(this._bodyTypeSelect);
cy.xpath(this._bodyTypeToSelect(subTabName)).should("be.visible").click();
this.agHelper.GetNClick(this._bodyTypeToSelect(subTabName));

@coderabbitai coderabbitai Bot Aug 26, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reintroduce visibility assertion or ensure element is interactable

The visibility assertion has been removed before clicking the element. This might lead to runtime errors if the element is not visible at the time of the click. Consider reintroducing the visibility assertion or ensuring the element is interactable before clicking it.

- this.agHelper.GetNClick(this._bodyTypeToSelect(subTabName));
+ cy.xpath(this._bodyTypeToSelect(subTabName)).should("be.visible");
+ this.agHelper.GetNClick(this._bodyTypeToSelect(subTabName));

Committable suggestion was skipped due to low confidence.

}

AssertRightPaneSelectedTab(tabName: RightPaneTabs) {
Expand Down