test: updated helper for airgap view permission

[NandanAnantharamu]

AirGap test for CE
/ok-to-test tags="@tag.All"
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4726

Summary by CodeRabbit

• Improvements
  • Streamlined logic for handling air-gapped scenarios, enhancing clarity and performance.
  • Removed unnecessary checks related to workspace validation for a more efficient process.

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10352641842
Commit: c09ed04
Cypress dashboard.
Tags: @tag.All
Spec:

---

Mon, 12 Aug 2024 14:28:39 UTC

[coderabbitai]

Walkthrough

The recent changes to the AggregateHelper class streamline the VisitNAssert method by simplifying its logic concerning the apiToValidate parameter and the handling of the AIRGAPPED environment variable. The previous complex checks have been replaced with a more straightforward approach that enhances clarity and efficiency, particularly in air-gapped environments where no actions are required.

Changes

File Path	Change Summary
app/client/cypress/support/Pages/AggregateHelper.ts	The VisitNAssert method was modified to remove the checks for "getAllWorkspaces" and the sleep function. Now it solely checks for the AIRGAPPED variable, doing nothing if true.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AggregateHelper
    participant Environment

    User->>AggregateHelper: Call VisitNAssert(apiToValidate)
    AggregateHelper->>Environment: Check AIRGAPPED status
    alt AIRGAPPED is true
        AggregateHelper->>User: No actions needed (air-gapped)
    else AIRGAPPED is false
        AggregateHelper->>User: Proceed with actions based on apiToValidate
    end

Loading

Poem

In code we found a clearer way,
The logic flows, no time to sway.
With AIRGAPPED checks, we simplify,
In quiet zones, no need to try.
A dance of lines, a joyful tune,
Our code now sings beneath the moon! 🌙✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b64d5c8 and c09ed04.

Files selected for processing (1)

• app/client/cypress/support/Pages/AggregateHelper.ts (1 hunks)

Additional context used

Path-based instructions (1)

app/client/cypress/support/Pages/AggregateHelper.ts (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

Additional comments not posted (1)

app/client/cypress/support/Pages/AggregateHelper.ts (1)

1763-1764: Good simplification of logic in VisitNAssert.

The removal of the specific check for "getAllWorkspaces" and the sleep function improves clarity and performance. Ensure that this change does not affect any other part of the codebase that might rely on the previous behavior.