chore: Update env variable used for update persistent DB URL#35526
chore: Update env variable used for update persistent DB URL#35526
Conversation
WalkthroughThis update focuses on a naming convention change where the constant Changes
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
the
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- app/server/appsmith-server/src/main/java/com/appsmith/server/constants/EnvVariables.java (1 hunks)
- app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/EnvManagerTest.java (8 hunks)
Files skipped from review due to trivial changes (1)
- app/server/appsmith-server/src/main/java/com/appsmith/server/constants/EnvVariables.java
Additional comments not posted (9)
app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/EnvManagerTest.java (9)
119-148: Great job on updating the variable name!The changes to use
APPSMITH_DB_URLinstead ofAPPSMITH_MONGODB_URIare consistent and correct. This ensures the test reflects the updated environment variable name.
156-167: Nice update on handling empty values!The transition to
APPSMITH_DB_URLis well-executed, and the test correctly handles empty values.
Line range hint
173-199:
Well done on managing quoted values!The update to
APPSMITH_DB_URLis consistent, and the test effectively verifies handling of quoted values.
208-211: Good work on parsing empty values!The change to
APPSMITH_DB_URLis correctly reflected in the test, ensuring accurate parsing of empty values.
221-223: Excellent handling of quoted values!The update to
APPSMITH_DB_URLis consistent, and the test accurately verifies parsing of quoted values.
218-218: No changes related to the PR objectives.This test method does not involve
APPSMITH_DB_URL. No issues are present.
243-248: Great job on handling disallowed variables!The update to
APPSMITH_DB_URLis correctly integrated, ensuring the test accurately handles disallowed variables.
257-265: Nice update on adding new variables!The transition to
APPSMITH_DB_URLis well-executed, and the test effectively verifies the addition of new variables.
275-283: Well done on setting values with quotes!The update to
APPSMITH_DB_URLis consistent, and the test accurately verifies setting values with quotes.
…gres and MongoDB URL
abhvsn
added
ok-to-test
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/client/src/pages/AdminSettings/config/advanced.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/src/pages/AdminSettings/config/advanced.ts
Failed server tests
|
2 participants
Description
PR to fix the issue with DB url update from admin settings page. When we migrated the env variable to
APPSMITH_DB_URLinstead ofAPPSMITH_MONGODB_URIthis functionality broke. We had a discussion to remove this update functionality as this does not work in all the setups. But as QA has already started pointing this as an issue raising this PR.Automation
/ok-to-test tags="@tag.Settings"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10297374384
Commit: dbef20c
Cypress dashboard.
Tags:
@tag.SettingsSpec:
Thu, 08 Aug 2024 07:13:51 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes