test: add ordering for theme import test to fix flakiness#35473
test: add ordering for theme import test to fix flakiness#35473nidhi-nair merged 2 commits intoreleasefrom
Conversation
WalkthroughThe recent updates to the Changes
Sequence Diagram(s)sequenceDiagram
participant A as Test Runner
participant B as ThemeImportableServiceCETest
A->>B: Start Test Execution
B->>A: Execute importThemesToApplication_WhenBothImportedThemesAreCustom_NewThemesCreated
B->>A: Execute importThemesToApplication_ApplicationThemeNotFound_DefaultThemeImported
A->>B: Finish Test Execution
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
skip-changelog
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java (3 hunks)
Additional comments not posted (2)
app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java (2)
163-164: Good practice: Test order specified.The addition of the
@Order(1)annotation ensures that this test runs first, which is crucial for maintaining the sequence of test execution.
206-207: Good practice: Test order specified.The addition of the
@Order(2)annotation ensures that this test runs second, maintaining the sequence of test execution.
nidhi-nair
left a comment
nidhi-nair
left a comment
There was a problem hiding this comment.
Could you please help understand why these tests are dependent on each other?
Failed server tests
|
|
@nidhi-nair Its because of the create application flow method that was used by both methods was causing the ids to get messed up. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/ThemeImportableServiceCETest.java
Failed server tests
|
1 similar comment
Failed server tests
|
2 participants
Description
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit