Skip to content

test: fix flaky inline editing 2 spec #35426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacquesikot merged 6 commits into from
Aug 12, 2024
Merged

test: fix flaky inline editing 2 spec #35426

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52b1868
fix test cases
jacquesikot Aug 5, 2024
71adba8
add Inline_editing_2_spec.js to limited-tests
jacquesikot Aug 5, 2024
41cd2e7
update DEFAULT_NON_WRAP_CELL_COLUMN_HEIGHT value
jacquesikot Aug 5, 2024
ccf6b95
revert limited-tests.txt change
jacquesikot Aug 6, 2024
83caf57
remove redundant cy.wait
jacquesikot Aug 6, 2024
83116d9
swap DragDropNVerify for dragAndDropToCanvas in 7 test case
jacquesikot Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ describe(
agHelper.AddDsl("Table/InlineEditingDSL");
});

let propPaneBack = "[data-testid='t--property-pane-back-btn']";

it("1. should check that onDiscard event is working", () => {
cy.openPropertyPane("tablewidgetv2");
table.toggleColumnEditableViaColSettingsPane("step", "v2", true, true);
Expand All @@ -51,7 +49,7 @@ describe(
it("2. should check that inline editing works with text wrapping disabled", () => {
agHelper.AddDsl("Table/InlineEditingDSL");
cy.openPropertyPane("tablewidgetv2");
table.toggleColumnEditableViaColSettingsPane("step", "v2", false, true);
table.toggleColumnEditableViaColSettingsPane("step", "v2", true, true);
cy.editTableCell(0, 0);
cy.get(
"[data-colindex=0][data-rowindex=0] .t--inlined-cell-editor input.bp3-input",
Expand All @@ -71,13 +69,16 @@ describe(
).should("not.be.disabled");
});

it("4. should check that doesn't grow taller when text wrapping is disabled", () => {
it("4. should check that cell column height doesn't grow taller when text wrapping is disabled", () => {
const DEFAULT_NON_WRAP_CELL_COLUMN_HEIGHT = 28;
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
table.EnableEditableOfColumn("step");
table.toggleColumnEditableViaColSettingsPane("step", "v2", true, true);
table.EditTableCell(0, 0, "", false);
agHelper.GetHeight(table._editCellEditor);
cy.get("@eleHeight").then(($initiaHeight) => {
expect(Number($initiaHeight)).to.eq(28);
expect(Number($initiaHeight.toFixed())).to.eq(
DEFAULT_NON_WRAP_CELL_COLUMN_HEIGHT,
);
table.EditTableCell(
1,
0,
Expand All @@ -91,9 +92,10 @@ describe(
});
});

it("5. should check that grows taller when text wrapping is enabled", () => {
it("5. should check that cell column height grows taller when text wrapping is enabled", () => {
const MIN_WRAP_CELL_COLUMN_HEIGHT = 34;
EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
table.EnableEditableOfColumn("step");
table.toggleColumnEditableViaColSettingsPane("step", "v2", true, true);
table.EditColumn("step");
propPane.TogglePropertyState("Cell Wrapping", "On");
table.EditTableCell(
Expand All @@ -104,7 +106,9 @@ describe(
);
agHelper.GetHeight(table._editCellEditor);
cy.get("@eleHeight").then(($newHeight) => {
expect(Number($newHeight)).to.be.greaterThan(34);
expect(Number($newHeight)).to.be.greaterThan(
MIN_WRAP_CELL_COLUMN_HEIGHT,
);
});
});

Expand All @@ -130,7 +134,7 @@ describe(

cy.openPropertyPane("tablewidgetv2");

table.toggleColumnEditableViaColSettingsPane("step", "v2", false, true);
table.toggleColumnEditableViaColSettingsPane("step", "v2", true, true);
cy.wait(1000);
Comment thread
jacquesikot marked this conversation as resolved.
Outdated

// case 2: check if updatedRowIndex is 0, when cell at row 0 is updated.
Expand Down Expand Up @@ -175,7 +179,7 @@ describe(
);

EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
table.EnableEditableOfColumn("step");
table.toggleColumnEditableViaColSettingsPane("step", "v2", true, true);
agHelper.GetNClick(table._updateMode("Multi"), 0, false, 1000);

// case 1: check if updatedRowIndex is 0, when cell at row 0 is updated.
Expand Down
2 changes: 1 addition & 1 deletion app/client/cypress/limited-tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# To run only limited tests - give the spec names in below format:
cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
cypress/e2e/Regression/ClientSide/Widgets/TableV2/Inline_editing_2_spec.js

# For running all specs - uncomment below:
#cypress/e2e/**/**/*
Expand Down