fix: table save row button onclick function

app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/mysql_spec.ts

@@ -14,88 +14,78 @@ import EditorNavigation, {
 
 const oneClickBinding = new OneClickBinding();
 
-// TODO: Adds two rows on click of save row will debug and fix this in a different PR - Sangeeth
-describe.skip("Table widget one click binding feature", () => {
-  it("1.should check that queries are created and bound to table widget properly", () => {
-    entityExplorer.DragDropWidgetNVerify(draggableWidgets.TABLE, 400);
+describe(
+  "Table widget one click binding feature",
+  { tags: ["@tag.Widget"] },
+  () => {
+    it("1.should check that queries are created and bound to table widget properly", () => {
+      entityExplorer.DragDropWidgetNVerify(draggableWidgets.TABLE, 400);
 
-    dataSources.CreateDataSource("MySql");
+      dataSources.CreateDataSource("MySql");
 
-    cy.get("@dsName").then((dsName) => {
-      EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
+      cy.get("@dsName").then((dsName) => {
+        EditorNavigation.SelectEntityByName("Table1", EntityType.Widget);
 
-      oneClickBinding.ChooseAndAssertForm(`${dsName}`, dsName, "configs", {
-        searchableColumn: "configName",
+        oneClickBinding.ChooseAndAssertForm(`${dsName}`, dsName, "configs", {
+          searchableColumn: "configName",
+        });
       });
-    });
-
-    agHelper.GetNClick(oneClickBindingLocator.connectData);
-
-    assertHelper.AssertNetworkStatus("@postExecute");
-
-    agHelper.Sleep(2000);
-
-    [
-      "id",
-      "configName",
-      "configJson",
-      "configVersion",
-      "updatedAt",
-      "updatedBy",
-    ].forEach((column) => {
-      agHelper.AssertElementExist(table._headerCell(column));
-    });
-
-    agHelper.GetNClick(table._addNewRow, 0, true);
-
-    table.EditTableCell(0, 1, "One Click Config", false);
 
-    table.UpdateTableCell(0, 2, `{{}"key":"oneClick"}`);
-    table.UpdateTableCell(0, 3, 36);
-    table.UpdateTableCell(0, 4, "2023-07-03 15:30:00", false, true);
+      agHelper.GetNClick(oneClickBindingLocator.connectData);
 
-    agHelper.Sleep(2000);
+      assertHelper.AssertNetworkStatus("@postExecute");
 
-    agHelper.GetNClick(table._saveNewRow, 0, true);
+      [
+        "id",
+        "configName",
+        "configJson",
+        "configVersion",
+        "updatedAt",
+        "updatedBy",
+      ].forEach((column) => {
+        agHelper.AssertElementExist(table._headerCell(column));
+      });
 
-    assertHelper.AssertNetworkStatus("@postExecute");
+      agHelper.GetNClick(table._addNewRow, 0, true);
 
-    agHelper.TypeText(table._searchInput, "One Click Config");
+      table.EditTableCell(0, 1, "One Click Config", false);
 
-    assertHelper.AssertNetworkStatus("@postExecute");
+      table.UpdateTableCell(0, 2, `{{}"key":"oneClick"}`);
+      table.UpdateTableCell(0, 3, 36);
+      table.UpdateTableCell(0, 4, "2023-07-03 15:30:00", false, true);
 
-    agHelper.AssertElementExist(table._bodyCell("One Click Config"));
+      agHelper.GetNClick(table._saveNewRow, 0, true);
 
-    agHelper.Sleep(1000);
+      assertHelper.AssertNetworkStatus("@postExecute");
 
-    table.EditTableCell(0, 1, "Bindings", false);
-    table.EditTableCell(0, 4, "2023-07-03 15:30:00", false);
+      agHelper.TypeText(table._searchInput, "One Click Config");
 
-    agHelper.Sleep(1000);
+      assertHelper.AssertNetworkStatus("@postExecute");
 
-    (cy as any).AssertTableRowSavable(6, 0);
+      agHelper.AssertElementExist(table._bodyCell("One Click Config"));
 
-    (cy as any).saveTableRow(6, 0);
+      table.EditTableCell(0, 1, "Bindings", false);
+      table.EditTableCell(0, 4, "2023-07-03 15:30:00", false);
 
-    assertHelper.AssertNetworkStatus("@postExecute");
+      (cy as any).AssertTableRowSavable(6, 0);
 
-    assertHelper.AssertNetworkStatus("@postExecute");
+      (cy as any).saveTableRow(6, 0);
 
-    agHelper.Sleep(500);
-    agHelper.ClearNType(table._searchInput, "Bindings");
+      assertHelper.AssertNetworkStatus("@postExecute");
 
-    assertHelper.AssertNetworkStatus("@postExecute");
+      assertHelper.AssertNetworkStatus("@postExecute");
 
-    agHelper.Sleep(2000);
+      agHelper.ClearNType(table._searchInput, "Bindings");
 
-    agHelper.AssertElementExist(table._bodyCell("Bindings"));
+      assertHelper.AssertNetworkStatus("@postExecute");
 
-    agHelper.ClearNType(table._searchInput, "One Click Config");
+      agHelper.AssertElementExist(table._bodyCell("Bindings"));
 
-    assertHelper.AssertNetworkStatus("@postExecute");
+      agHelper.ClearNType(table._searchInput, "One Click Config");
 
-    agHelper.Sleep(2000);
+      assertHelper.AssertNetworkStatus("@postExecute");
 
-    agHelper.AssertElementAbsence(table._bodyCell("One Click Config"));
-  });
-});
+      agHelper.AssertElementAbsence(table._bodyCell("One Click Config"));
+    });
+  },
+);

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts

@@ -363,6 +363,12 @@ describe(
       PageLeftPane.switchSegment(PagePaneSegment.UI);
       cy.openPropertyPane("tablewidgetv2");
       cy.editColumn("step");
+      cy.get(".t--property-control-filterable input").then(($checkbox) => {
+        // Check if the checkbox is checked
+        if (!$checkbox.is(":checked")) {
+          cy.wrap($checkbox).click();
+        }
+      });
       cy.get(".t--property-control-serversidefiltering input").click();
       cy.updateCodeInput(
         ".t--property-pane-section-selectproperties",

app/client/cypress/limited-tests.txt

@@ -1,5 +1,6 @@
 # To run only limited tests - give the spec names in below format:
-cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
+cypress/e2e/Regression/ClientSide/OneClickBinding/TableWidget/mysql_spec.ts
+cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts
 
 # For running all specs - uncomment below:
 #cypress/e2e/**/**/*

app/client/src/widgets/TableWidgetV2/component/header/banner/AddNewRowBanner.tsx

@@ -69,7 +69,8 @@ function AddNewRowBannerComponent(props: AddNewRowBannerType) {
           className="t--save-new-row"
           disabled={props.disabledAddNewRowSave || isDiscardLoading}
           loading={isSaveLoading}
-          onClick={() => {
+          onClick={(event) => {
+            event.stopPropagation();
             setIsSaveLoading(true);
             props.onAddNewRowAction(AddNewRowActions.SAVE, () =>
               setIsSaveLoading(false),