chore: Remove google fonts imported from googleapis#35392
Conversation
WalkthroughThe recent changes indicate a strategic shift away from Google Fonts in the application's CSS, promoting the use of local or custom font assets. This transition aims to enhance branding consistency and potentially improve loading times by reducing reliance on external resources. Additionally, improvements to the GitHub Actions workflow enhance the clarity of output messages, making it easier for developers to track changes in the client folder. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10243060756. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/client/src/index.css (1 hunks)
Files skipped from review due to trivial changes (1)
- app/client/src/index.css
|
Deploy-Preview-URL: https://ce-35392.dp.appsmith.com |
|
@dvj1988 Can you ascertain airgapped users are not impacted by these changes? |
@vsvamsi1 I have tested it on my local using this document. Everything works as expected on airgapped. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/client-build.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/client-build.yml
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/client-build.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/client-build.yml
Description
Google fonts are served by the appsmith instance and change that was introduced in this PR. This PR removes redundant the import of google fonts from googleapis.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10270353461
Commit: 142bcc8
Cypress dashboard.
Tags:
@tag.AllSpec:
Tue, 06 Aug 2024 17:21:17 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Usability Improvements