Skip to content

chore: Remove google fonts imported from googleapis#35392

Merged
dvj1988 merged 6 commits intoreleasefrom
chore/remove-google-fonts-googleapis
Aug 7, 2024
Merged

chore: Remove google fonts imported from googleapis#35392
dvj1988 merged 6 commits intoreleasefrom
chore/remove-google-fonts-googleapis

Conversation

@dvj1988
Copy link

@dvj1988 dvj1988 commented Aug 5, 2024

Description

Google fonts are served by the appsmith instance and change that was introduced in this PR. This PR removes redundant the import of google fonts from googleapis.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10270353461
Commit: 142bcc8
Cypress dashboard.
Tags: @tag.All
Spec:


Tue, 06 Aug 2024 17:21:17 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Transitioned to a fully local/custom font strategy, enhancing branding consistency and potentially improving load times.
  • Usability Improvements

    • Enhanced output readability in the GitHub Actions workflow, making it easier for users to identify changed files.
    • Updated the file change detection mechanism in the GitHub Actions workflow for better performance and clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 5, 2024

Walkthrough

The recent changes indicate a strategic shift away from Google Fonts in the application's CSS, promoting the use of local or custom font assets. This transition aims to enhance branding consistency and potentially improve loading times by reducing reliance on external resources. Additionally, improvements to the GitHub Actions workflow enhance the clarity of output messages, making it easier for developers to track changes in the client folder.

Changes

File Change Summary
app/client/src/index.css Removed import statement for Google Fonts, focusing on local font assets.
.github/workflows/client-build.yml Enhanced output formatting for changed files in GitHub Actions to improve readability.
.github/workflows/client-build.yml Updated to v44 of the tj-actions/changed-files action, improving change detection and output.

Poem

In the realm of style where fonts once danced,
A shift away from Google, a bold new chance.
Local treasures we now embrace,
For a brand that's strong, with its own face.
Loading times will quicken, so let’s rejoice!
In custom fonts, we find our voice! 🎨✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dvj1988
Copy link
Author

dvj1988 commented Aug 5, 2024

/build-deploy-preview skip-tests=true

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Aug 5, 2024
@github-actions
Copy link

github-actions bot commented Aug 5, 2024

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10243060756.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 35392.
recreate: .

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7adb33d and b466cee.

Files selected for processing (1)
  • app/client/src/index.css (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/index.css

@github-actions
Copy link

github-actions bot commented Aug 5, 2024

Deploy-Preview-URL: https://ce-35392.dp.appsmith.com

@dvj1988 dvj1988 self-assigned this Aug 5, 2024
@dvj1988 dvj1988 added the ok-to-test Required label for CI label Aug 5, 2024
@dvj1988 dvj1988 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Aug 5, 2024
@vsvamsi1 vsvamsi1 requested a review from jsartisan August 5, 2024 11:05
@vsvamsi1
Copy link
Contributor

vsvamsi1 commented Aug 5, 2024

@dvj1988 Can you ascertain airgapped users are not impacted by these changes?

@dvj1988
Copy link
Author

dvj1988 commented Aug 5, 2024

@dvj1988 Can you ascertain airgapped users are not impacted by these changes?

@vsvamsi1 I have tested it on my local using this document. Everything works as expected on airgapped.

vsvamsi1
vsvamsi1 previously approved these changes Aug 5, 2024
@dvj1988 dvj1988 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Aug 6, 2024
@dvj1988 dvj1988 requested a review from sharat87 as a code owner August 6, 2024 13:34
@dvj1988 dvj1988 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Aug 6, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b466cee and f58830b.

Files selected for processing (1)
  • .github/workflows/client-build.yml (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/client-build.yml

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f58830b and 1270c65.

Files selected for processing (1)
  • .github/workflows/client-build.yml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/client-build.yml

@dvj1988 dvj1988 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Aug 6, 2024
@dvj1988 dvj1988 removed the request for review from sharat87 August 6, 2024 16:26
@dvj1988 dvj1988 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Aug 6, 2024
@dvj1988 dvj1988 requested a review from vsvamsi1 August 6, 2024 17:22
@dvj1988 dvj1988 merged commit 43518e6 into release Aug 7, 2024
@dvj1988 dvj1988 deleted the chore/remove-google-fonts-googleapis branch August 7, 2024 03:19
@ichik ichik mentioned this pull request Aug 28, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants