chore: Add hostname as common attr on all spans#35388
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent changes enhance the telemetry capabilities of the application by adding a Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Telemetry
Client->>Telemetry: Request telemetry attributes
Telemetry->>Client: Return common telemetry attributes with hostname
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/client/src/UITelemetry/generateTraces.ts (1 hunks)
Additional comments not posted (1)
app/client/src/UITelemetry/generateTraces.ts (1)
45-45: Good job adding the hostname attribute!The addition of the
hostnameproperty to the telemetry attributes is a valuable enhancement for tracking and analysis. Ensure that this change is thoroughly tested to confirm that it correctly captures the hostname and does not introduce any issues.
Description
Some of the self hosted instances are sending data with the entitiy.name as Appsmith Production OTLP. Therefore we need another attribute to slice all the cloud data and hostname will be unique to each instance.
Fixes #
Issue Numberor
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10234910845
Commit: b616a08
Cypress dashboard.
Tags:
@tag.SanitySpec:
Sun, 04 Aug 2024 09:13:54 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
hostnameproperty, improving tracking and analysis of telemetry events based on the specific web page host.