Skip to content

chore: apply spotless precommit #35054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishabhrathod01 merged 3 commits into from
Jul 22, 2024
Merged

chore: apply spotless precommit #35054

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3739dbd
chore: apply spotless precommit
Jul 22, 2024
49c6f9c
fallback to manual run if precommit fails
Jul 22, 2024
5872049
apply spotless to all files and commit staged files
Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions app/client/.husky/check-staged-files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,22 @@ if [ "$is_merge_commit" ]; then
echo "Skipping server and client checks for merge commit"
else
if [ "$is_server_change" -ge 1 ]; then
echo "Running Spotless check ..."
echo "- Applying Spotless to server files..."
pushd app/server > /dev/null
if (mvn spotless:check 1> /dev/null && popd > /dev/null) then
popd
if mvn spotless:apply; then
echo "✔ Spotless applied successfully to server files"
git add .
Comment thread
rishabhrathod01 marked this conversation as resolved.
Outdated
popd > /dev/null
else
echo "Spotless check failed, please run mvn spotless:apply"
echo "Spotless apply failed for server files"
popd > /dev/null
exit 1
fi
else
echo "Skipping server side check..."
echo "Skipping server side check..."
fi

if [ "$is_client_change" -ge 1 ]; then
if [ "$is_client_change" -ge 1 ]; then
echo "Running client check ..."
npx lint-staged --cwd app/client
else
Expand Down
2 changes: 0 additions & 2 deletions app/server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@
<goals>
<goal>apply</goal>
</goals>
<!-- This gets triggered automatically when we run the build script -->
<phase>compile</phase>
</execution>
</executions>
</plugin>
Expand Down