test: Updated file name for remove duplicate by sagar-qa007 · Pull Request #34821 · appsmithorg/appsmith

sagar-qa007 · 2024-07-09T10:22:43Z

Description

Renamed the file name to remove duplicity for FileNames.

Fixes #34799

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9891607703
Commit: 0cf957b
Cypress dashboard.
Tags: @tag.All
Spec:

Thu, 11 Jul 2024 13:34:23 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

Tests
- Updated import paths in testing files to ensure compatibility with the latest data structure.
- Enhanced test descriptions and scenarios for the Admin settings page in the Enterprise context, including redirection and button functionalities.

coderabbitai · 2024-07-09T10:22:57Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files selected but had no reviewable changes (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

This update involves modifications to Cypress E2E test files, focusing on import path adjustments and the enhancement of test descriptions within an Enterprise context. Additionally, a linter task is outlined for identifying and managing duplicate filenames in spec files.

Changes

Files	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts`	Updated import path in `homePage.ImportApp()` from `"Table/TableFilterImportApp.json"` to `"TableV2FilterImportApp.json"`.
`app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js`	Updated test suite description to "Admin settings page in Enterprise"; introduced changes for testing Admin settings, intercepts, redirection, and button functionalities.

Assessment against linked issues

Objective	Addressed	Explanation
Add linter for unique names for specs (SubTasks):
- Find duplicate filename and store in google sheet (#34799)	❌	This task is not addressed in the code changes.
- Custom linter development (#34799)	❌	This task is not addressed in the code changes.
- Linter testing (#34799)	❌	This task is not addressed in the code changes.

Poem

Among the code, where changes weave,
Paths updated, tests believe.
Admin's realm checks galore,
Widgets hum and tests explore.
A bunny's delight, code refined,
In Cypress fields, success we'll find. 🐇

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 08c3ea9 and 37d30ae.

Files selected for processing (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts (1 hunks)
app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_EE_spec.js (1 hunks)

Files skipped from review due to trivial changes (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts
app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_EE_spec.js

ApekshaBhosale

what sis the naming convention are you suggesting for all devs from going onwards?

app/client/cypress/fixtures/Table/TableFilterImportAppV2.json

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_EE_spec.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 37d30ae and 09fa750.

Files selected for processing (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts (1 hunks)
app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts

Additional context used

Path-based instructions (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js (1)

Pattern app/client/cypress/**/**.*: Follow best practices for Cypress code and e2e automation.
Avoid using cy.wait in code.
Avoid using cy.pause in code.
Use variables for locators, not strings.
Use data-* attributes for selectors; avoid Xpaths and CSS attributes.
Avoid selectors like .btn.submit or button[type=submit].
Perform logins via API with LoginFromAPI.
Only interact with controlled sites/servers.
Ensure tests can run with it.only and are independent.
Use before, beforeEach, after, afterEach correctly; clean state before tests.
Check new specs for flakiness by running them 10 times on CI.
Use multiple assertions; don't treat Cypress as unit tests.
Use constants for strings.
Include datasource operations in before hooks.

Additional comments not posted (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js (1)

9-9: LGTM! The test suite description update improves specificity.

The updated description "Admin settings page in Enterprise" is more specific and helps in better understanding the context of the tests.

sagar-qa007 · 2024-07-09T12:13:26Z

Naming conventions for duplicate file that I can suggest. We can discuss more scenarios as well :

Use specific function name even if spec is doing most of the steps same. E.g. JSONForm_MongoDB_spec.js
Use folder/directory name to make things more clear about function in prefix. E.g. DynamicaHeightStatbox_spec.js.

Here is the Google sheet for the duplicate name remove and few examples are given:

https://docs.google.com/spreadsheets/d/1UAmtwvKSjFOm8_4uXCSmwbL_YDutlVv1wdXn-xQ18WM/edit?usp=sharing

ApekshaBhosale · 2024-07-09T12:15:41Z

@sagar-qa007 let's add this to our best practices doc

github-actions · 2024-07-10T05:55:15Z

🔴 There's new test files in JS, please port to TS and re-trigger Cypress tests:

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 09fa750 and e3b4571.

Files selected for processing (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

github-actions · 2024-07-10T06:04:36Z

🔴 There's new test files in JS, please port to TS and re-trigger Cypress tests:

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

app/client/cypress/fixtures/Table/TableFilterImportAppWithVersionTwo.json

github-actions · 2024-07-10T07:35:30Z

🔴 There's new test files in JS, please port to TS and re-trigger Cypress tests:

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

github-actions · 2024-07-10T08:32:04Z

🔴 There's new test files in JS, please port to TS and re-trigger Cypress tests:

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

github-actions · 2024-07-10T08:35:59Z

🔴 There's new test files in JS, please port to TS and re-trigger Cypress tests:

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

github-actions · 2024-07-10T08:59:42Z

🔴 There's new test files in JS, please port to TS and re-trigger Cypress tests:

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e3b4571 and 0365fc8.

Files selected for processing (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js (2 hunks)

Files skipped from review due to trivial changes (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0365fc8 and 6d80679.

Files selected for processing (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2Filter2_2_Spec.ts

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6d80679 and 2323ea3.

Files selected for processing (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_Settings_NoAccess_spec.js

Updated file name for remove duplicate

37d30ae

sagar-qa007 added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jul 9, 2024

sagar-qa007 requested a review from ApekshaBhosale as a code owner July 9, 2024 10:22

sagar-qa007 added the ok-to-test Required label for CI label Jul 9, 2024

github-actions bot removed the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jul 9, 2024

coderabbitai bot reviewed Jul 9, 2024

View reviewed changes

ApekshaBhosale suggested changes Jul 9, 2024

View reviewed changes

app/client/cypress/fixtures/Table/TableFilterImportAppV2.json Show resolved Hide resolved

app/client/cypress/e2e/Regression/Enterprise/AdminSettings/Admin_settings_EE_spec.js Show resolved Hide resolved

Updated changes are per PR comments

09fa750

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 9, 2024

coderabbitai bot reviewed Jul 9, 2024

View reviewed changes

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 9, 2024

Removed deprecated files

49682b6

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 10, 2024

Prettier solved

e3b4571

coderabbitai bot reviewed Jul 10, 2024

View reviewed changes

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 10, 2024

ApekshaBhosale changed the title ~~task: Updated file name for remove duplicate~~ test: Updated file name for remove duplicate Jul 10, 2024

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Jul 10, 2024

ApekshaBhosale suggested changes Jul 10, 2024

View reviewed changes

app/client/cypress/fixtures/Table/TableFilterImportAppWithVersionTwo.json Show resolved Hide resolved

sagar-qa007 removed the ok-to-test Required label for CI label Jul 10, 2024

ApekshaBhosale previously approved these changes Jul 10, 2024

View reviewed changes

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 10, 2024

Reverted the changes

0365fc8

sagar-qa007 dismissed ApekshaBhosale’s stale review via 0365fc8 July 10, 2024 11:30

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 10, 2024

coderabbitai bot reviewed Jul 10, 2024

View reviewed changes

Missed change : Updated name as test failed.

6d80679

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 10, 2024

coderabbitai bot reviewed Jul 10, 2024

View reviewed changes

File updated

2323ea3

coderabbitai bot reviewed Jul 11, 2024

View reviewed changes

Prettier applied

0cf957b

sagar-qa007 added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 11, 2024

ApekshaBhosale approved these changes Jul 11, 2024

View reviewed changes

sagar-qa007 merged commit 3078d81 into release Jul 12, 2024

sagar-qa007 deleted the fix/duplicateFileName branch July 12, 2024 04:37

coderabbitai bot mentioned this pull request Nov 11, 2024

chore: Updated js file to ts files #37312

Closed

2 tasks

coderabbitai bot mentioned this pull request Nov 19, 2024

test: new test cases framework functions and Action selector #37566

Merged

2 tasks

This was referenced Dec 6, 2024

fix: Fix flaky test case for the iframe spec #38018

Merged

fix:Widget Column test case fix #38045

Merged

Conversation

sagar-qa007 commented Jul 9, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

ApekshaBhosale left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

sagar-qa007 commented Jul 9, 2024

Uh oh!

ApekshaBhosale commented Jul 9, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

github-actions bot commented Jul 10, 2024

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sagar-qa007 commented Jul 9, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Jul 9, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)