Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ public interface NewActionServiceCE extends CrudService<NewAction, String> {

Mono<NewAction> validateAction(NewAction newAction);

Mono<NewAction> validateAction(NewAction newAction, boolean isDryOps);
Comment thread
AnaghHegde marked this conversation as resolved.

Mono<Void> bulkValidateAndInsertActionInRepository(List<NewAction> newActionList);

Mono<Void> bulkValidateAndUpdateActionInRepository(List<NewAction> newActionList);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,11 @@ public Mono<ActionDTO> validateAndSaveActionToRepository(NewAction newAction) {

@Override
public Mono<NewAction> validateAction(NewAction newAction) {
return validateAction(newAction, false);
}

@Override
public Mono<NewAction> validateAction(NewAction newAction, boolean isDryOps) {
this.setGitSyncIdInNewAction(newAction);

ActionDTO action = newAction.getUnpublishedAction();
Expand Down Expand Up @@ -370,15 +375,23 @@ public Mono<NewAction> validateAction(NewAction newAction) {
} else {
// TODO: check if datasource should be fetched with edit during action create or update.
// Data source already exists. Find the same.
datasourceMono = datasourceService
.findById(action.getDatasource().getId())
.switchIfEmpty(Mono.defer(() -> {
action.setIsValid(false);
invalids.add(AppsmithError.NO_RESOURCE_FOUND.getMessage(
FieldName.DATASOURCE,
action.getDatasource().getId()));
return Mono.just(action.getDatasource());
}))

if (isDryOps) {
datasourceMono = Mono.just(action.getDatasource());
} else {
datasourceMono = datasourceService
.findById(action.getDatasource().getId())
.switchIfEmpty(Mono.defer(() -> {
if (!isDryOps) {
action.setIsValid(false);
invalids.add(AppsmithError.NO_RESOURCE_FOUND.getMessage(
FieldName.DATASOURCE,
action.getDatasource().getId()));
}
return Mono.just(action.getDatasource());
}));
}
datasourceMono = datasourceMono
.map(datasource -> {
// datasource is found. Update the action.
newAction.setWorkspaceId(datasource.getWorkspaceId());
Expand Down Expand Up @@ -441,15 +454,15 @@ public Mono<NewAction> validateAction(NewAction newAction) {
@Override
public Mono<Void> bulkValidateAndInsertActionInRepository(List<NewAction> newActionList) {
return Flux.fromIterable(newActionList)
.flatMap(this::validateAction)
.flatMap(newAction -> validateAction(newAction, true))
.collectList()
.flatMap(repository::bulkInsert);
}

@Override
public Mono<Void> bulkValidateAndUpdateActionInRepository(List<NewAction> newActionList) {
return Flux.fromIterable(newActionList)
.flatMap(this::validateAction)
.flatMap(newAction -> validateAction(newAction, true))
.collectList()
.flatMap(repository::bulkUpdate);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,7 @@ private void updateDatasourceInAction(
.findFirst()
.orElse(datasource);
datasource.setIsAutoGenerated(false);
newAction.setWorkspaceId(datasource.getWorkspaceId());
Comment thread
AnaghHegde marked this conversation as resolved.
}

newAction.getUnpublishedAction().setDatasource(datasource);
Expand Down