Skip to content

feat: change value to label in onItemSelect inside SelectCell of table widget #34743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacquesikot merged 2 commits into from
Jul 9, 2024
Merged

feat: change value to label in onItemSelect inside SelectCell of table widget #34743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718d8a7
change value to label in onItemSelect inside SelectCell of table widget
jacquesikot Jul 4, 2024
330d0d3
add test to check that on option select uses label instead of value i…
jacquesikot Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 36 additions & 4 deletions app/client/cypress/e2e/Regression/ClientSide/Widgets/TableV2/columnTypes/Select1_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,39 @@ describe(
cy.discardTableRow(4, 0);
});

it("6. should check that currentRow is accessible in the select options", () => {
it("6. should check that on option select uses label as value in select cell (#34743)", () => {
cy.updateCodeInput(
".t--property-control-options",
`
[
{
"label": "#1label",
"value": "#1value"
},
{
"label": "#2label",
"value": "#2value"
},
{
"label": "#3label",
"value": "#3value"
}
]
`,
);
cy.editTableSelectCell(0, 0);
cy.get(".menu-item-link").contains("#3label").click();

_.agHelper.ValidateToastMessage("#3label");

cy.get(".menu-virtual-list").should("not.exist");
cy.readTableV2data(0, 0).then((val) => {
expect(val).to.equal("#3label");
});
cy.discardTableRow(4, 0);
});

it("7. should check that currentRow is accessible in the select options", () => {
cy.updateCodeInput(
".t--property-control-options",
`
Expand All @@ -199,7 +231,7 @@ describe(
cy.get(".menu-item-text").contains("#1").should("not.exist");
});

it("7. should check that 'same select option in new row' property is working", () => {
it("8. should check that 'same select option in new row' property is working", () => {
_.propPane.NavigateBackToPropertyPane();

const checkSameOptionsInNewRowWhileEditing = () => {
Expand Down Expand Up @@ -265,7 +297,7 @@ describe(
checkSameOptionsWhileAddingNewRow();
});

it("8. should check that 'new row select options' is working", () => {
it("9. should check that 'new row select options' is working", () => {
const checkNewRowOptions = () => {
// New row select options should be visible when "Same options in new row" is turned off
_.propPane.TogglePropertyState("Same options in new row", "Off");
Expand Down Expand Up @@ -330,7 +362,7 @@ describe(
checkNoOptionState();
});

it("9. should check that server side filering is working", () => {
it("10. should check that server side filering is working", () => {
_.dataSources.CreateDataSource("Postgres");
_.dataSources.CreateQueryAfterDSSaved(
"SELECT * FROM public.astronauts {{this.params.filterText ? `WHERE name LIKE '%${this.params.filterText}%'` : ''}} LIMIT 10;",
Expand Down
2 changes: 1 addition & 1 deletion app/client/src/widgets/TableWidgetV2/component/cellComponents/SelectCell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ export const SelectCell = (props: SelectProps) => {
const onSelect = useCallback(
(option: DropdownOption) => {
onItemSelect(
option.value || "",
option.label || "",
rowIndex,
alias,
onOptionSelectActionString,
Expand Down