revert: clean up datasource review page

[jacquesikot]

Reverts #34348

Summary by CodeRabbit

• New Features

  • Enhanced button display conditions based on plugin permissions in the Data Source Editor.

• Bug Fixes

  • Corrected logic for feature flags in Data Source Editor to ensure consistent button behavior.

• Refactor

  • Improved import structure and code readability in Data Source Editor components.

• Chores

  • Removed outdated feature flag checks for releaseDragDropBuildingBlocks across multiple files.

[coderabbitai]

Walkthrough

The recent changes center around refining how feature flags are used and how buttons are displayed across different parts of the app. Specifically, modifications include reordering and updating imports, adjusting feature flag usage, and altering button display logic based on plugin permissions. Key changes involve eliminating reliance on the releaseDragDropBuildingBlocks feature flag and improving the header actions in the datasource editor.

Changes

Files	Change Summary
app/client/src/ce/hooks/datasourceEditorHooks.tsx	Reordered imports, updated feature flag handling, and adjusted button display logic based on plugin permissions. Added React and Button imports, removed unused imports.
app/client/src/pages/Editor/DatasourceInfo/DatasourceViewModeSchema.tsx	Removed logic related to the releaseDragDropBuildingBlocks feature flag affecting the showGeneratePageBtn condition.
app/client/src/pages/Editor/DatasourceInfo/GoogleSheetSchema.tsx	Similarly, removed the releaseDragDropBuildingBlocks feature flag usage, impacting the condition for showing the showGeneratePageBtn.

Poem

In fields of code where features grow,
The flags that flutter soon must go. 🌱
With buttons bright and imports right,
Our datasources now take flight! 🚀
For every plugin, a tailored view,
This change brings something fresh and new. ✨

---

Tip

Early access features: enabled

We are currently testing the following features in early access:

• OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues.
• OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 33325dd and 2eb1767.

Files selected for processing (3)

• app/client/src/ce/hooks/datasourceEditorHooks.tsx (4 hunks)
• app/client/src/pages/Editor/DatasourceInfo/DatasourceViewModeSchema.tsx (2 hunks)
• app/client/src/pages/Editor/DatasourceInfo/GoogleSheetSchema.tsx (2 hunks)

Additional comments not posted (5)

app/client/src/ce/hooks/datasourceEditorHooks.tsx (3)

1-1: Added Import: React.

The import of React is necessary for JSX syntax.

---

2-2: Added Import: Button.

The import of Button from the design-system is necessary for the new button logic.

---

102-103: Ensure proper initialization of isNewQuerySecondaryButton.

The initialization of isNewQuerySecondaryButton with !!isPluginAllowedToPreviewData is correct, but ensure that isPluginAllowedToPreviewData is always a boolean.

app/client/src/pages/Editor/DatasourceInfo/DatasourceViewModeSchema.tsx (1)

Line range hint 51-51: Removed feature flag: releaseDragDropBuildingBlocks.

The removal of the feature flag releaseDragDropBuildingBlocks simplifies the logic for showGeneratePageBtn.

app/client/src/pages/Editor/DatasourceInfo/GoogleSheetSchema.tsx (1)

Line range hint 52-52: Removed feature flag: releaseDragDropBuildingBlocks.

The removal of the feature flag releaseDragDropBuildingBlocks simplifies the logic for showGeneratePageBtn.