Skip to content

test: adjust widget sidebar cypress tests to account for custom widget removal from Airgapped#34612

Merged
sharat87 merged 5 commits intoreleasefrom
test/fix-widget-sidebar-tests
Jul 2, 2024
Merged

test: adjust widget sidebar cypress tests to account for custom widget removal from Airgapped#34612
sharat87 merged 5 commits intoreleasefrom
test/fix-widget-sidebar-tests

Conversation

@jacquesikot
Copy link
Contributor

@jacquesikot jacquesikot commented Jul 1, 2024 •
edited by github-actions bot
Loading

Description

This PR removed custom widgets from Airgapped versions and this caused the widget sidebar tests to fail. This PR updated the required tests to account for this change.

Fixes #Issue Number
or
Fixes Issue URL

Automation

/ok-to-test tags="@tag.Widget"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9757281541
Commit: bd1e5ed
Cypress dashboard.
Tags: @tag.Widget

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Updated widgets catalog to display different widgets based on the airgapped environment.
    • Adjusted widget search behavior to align with the airgapped environment, enhancing search accuracy and display.

  • Bug Fixes

    • Fixed widget card display consistency when the AIRGAPPED environment variable is enabled.

@jacquesikot jacquesikot requested a review from rahulbarwal July 1, 2024 11:36
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 1, 2024 •
edited
Loading

Walkthrough

The Widgets_Sidebar.ts file has been updated to modify the list of widgets displayed based on the environment setting AIRGAPPED. Specifically, changes include adjusting the WIDGETS_CATALOG for content and display, as well as modifying the widget search behavior and tests accordingly.

Changes

File Path Change Summary
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts Adjusted WIDGETS_CATALOG content and display for airgapped environments, and updated widget search behavior and tests based on AIRGAPPED.

Poem

In the sidebar where widgets dwell,
Now they change with a story to tell.
Airgapped or not, the display will shift,
Showing charts, maps, and tables adrift.
A rabbit's touch in lines of code,
A tailored view in every mode. 🌟🐇

Tip

Early access features: enabled

We are currently testing the following features in early access:

  • OpenAI gpt-4o model for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.

Note:

  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jacquesikot jacquesikot added the ok-to-test Required label for CI label Jul 1, 2024
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Jul 1, 2024
coderabbitai[bot]
coderabbitai bot reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between dc99eb1 and 491ac14.

Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts (2 hunks)
Additional comments not posted (2)
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts (2)

73-82: LGTM! The widget catalog is correctly updated for the airgapped environment.

The WIDGETS_CATALOG.Content and WIDGETS_CATALOG.Display lists are appropriately modified based on the AIRGAPPED environment variable.

202-209: LGTM! The widget search behavior is correctly adapted for the airgapped environment.

The search behavior changes ensure that the correct number of widget cards are displayed based on the AIRGAPPED environment variable.

@jacquesikot jacquesikot requested a review from btsgh July 1, 2024 11:38
@jacquesikot jacquesikot requested a review from rahulbarwal July 1, 2024 13:03
@jacquesikot jacquesikot added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 1, 2024
coderabbitai[bot]
coderabbitai bot reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 491ac14 and 411096f.

Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts

rahulbarwal
rahulbarwal suggested changes Jul 1, 2024
View reviewed changes
@jacquesikot jacquesikot requested a review from rahulbarwal July 2, 2024 07:42
@jacquesikot jacquesikot added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jul 2, 2024
coderabbitai[bot]
coderabbitai bot reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 411096f and bd1e5ed.

Files selected for processing (1)
  • app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Widgets_Sidebar.ts

@sharat87 sharat87 merged commit 3075803 into release Jul 2, 2024
@sharat87 sharat87 deleted the test/fix-widget-sidebar-tests branch July 2, 2024 10:25
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Jul 10, 2024
@jacquesikot @Shivam-z
test: adjust widget sidebar cypress tests to account for custom widge…
eca9479 
…t removal from Airgapped (appsmithorg#34612)

## Description
This [PR](appsmithorg#34540) removed
custom widgets from Airgapped versions and this caused the widget
sidebar tests to fail. This PR updated the required tests to account for
this change.


Fixes #`Issue Number`  
_or_  
Fixes `Issue URL`

## Automation

/ok-to-test tags="@tag.Widget"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9757281541>
> Commit: bd1e5ed
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9757281541&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget`
<!-- end of auto-generated comment: Cypress test results  -->




## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Updated widgets catalog to display different widgets based on the
airgapped environment.
- Adjusted widget search behavior to align with the airgapped
environment, enhancing search accuracy and display.

- **Bug Fixes**
- Fixed widget card display consistency when the `AIRGAPPED` environment
variable is enabled.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ApekshaBhosale ApekshaBhosale Awaiting requested review from ApekshaBhosale

@btsgh btsgh Awaiting requested review from btsgh

+1 more reviewer

@rahulbarwal rahulbarwal rahulbarwal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacquesikot @rahulbarwal @sharat87