Skip to content

chore: update local uneval tree only for jsObjects and exit early for other entities #34524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashit-rath merged 3 commits into from
Jul 4, 2024
Merged

chore: update local uneval tree only for jsObjects and exit early for other entities #34524

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05da1cf
chore: update local uneval tree only for jsObjects and exit early for…
ashit-rath Jun 27, 2024
eb4cb9a
merged latest release
ashit-rath Jun 28, 2024
f242dfa
variable rename
ashit-rath Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/client/src/workers/common/DataTreeEvaluator/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,10 @@ export default class DataTreeEvaluator {
//add functions and variables to unevalTree
const unEvalJSCollection = JSObjectCollection.getUnEvalState();
Object.keys(unEvalJSCollection).forEach((update) => {
const entity = unevalTree[update];

if (!isJSAction(entity)) return;

const updates = unEvalJSCollection[update];
if (!!unevalTree[update]) {
Comment thread
ashit-rath marked this conversation as resolved.
Outdated
Object.keys(updates).forEach((key) => {
Expand Down