Skip to content

fix: workflow js func rename code split #34512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ayushpahwa merged 5 commits into from
Jun 28, 2024
Merged

fix: workflow js func rename code split #34512

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
662963f
update: added workflowid in type of jsaction api
ayushpahwa Jun 26, 2024
b4808a7
update: added workflowid in type of jsaction api
ayushpahwa Jun 26, 2024
ed46209
update: jspane saga rename function
ayushpahwa Jun 26, 2024
f981d68
fix: reset to release
ayushpahwa Jun 26, 2024
6da583f
fix: unit tests
ayushpahwa Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/client/src/ce/api/JSActionAPI.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export interface RefactorAction {
oldName: string;
collectionName: string;
moduleId?: string;
workflowId?: string;
contextType?: ActionParentEntityTypeInterface;
}
export interface RefactorActionRequest extends RefactorAction {
Expand Down
1 change: 1 addition & 0 deletions app/client/src/sagas/JSPaneSagas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ function* handleEachUpdateJSCollection(update: JSUpdate) {
collectionName: jsAction.name,
pageId: data.nameChangedActions[i].pageId || "",
moduleId: data.nameChangedActions[i].moduleId,
workflowId: data.nameChangedActions[i].workflowId,
oldName: data.nameChangedActions[i].oldName,
newName: data.nameChangedActions[i].newName,
},
Expand Down
2 changes: 2 additions & 0 deletions app/client/src/utils/JSPaneUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export interface JSCollectionDifference {
newName: string;
pageId: string;
moduleId?: string;
workflowId?: string;
}>;
changedVariables: Variable[];
}
Expand Down Expand Up @@ -104,6 +105,7 @@ export const getDifferenceInJSCollection = (
newName: newActions[i].name,
pageId: updateExisting.pageId,
moduleId: updateExisting.moduleId,
workflowId: updateExisting.workflowId,
});
newActions.splice(i, 1);
toBearchivedActions.splice(indexOfArchived, 1);
Expand Down