fix: Truncate title in tooltips in table cell if it exceeds 200 characters by rahulbarwal · Pull Request #34507 · appsmithorg/appsmith

rahulbarwal · 2024-06-26T11:58:09Z

Description

Truncate the title in tooltips if it exceeds 1000 characters to improve readability.

Fixes #23156
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Widget"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9697818492
Commit: a4007cb
Cypress dashboard.
Tags: @tag.Widget

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Improved tooltip functionality to automatically truncate text that exceeds a set character limit, enhancing readability.

Truncate the title in tooltips if it exceeds 1000 characters to improve readability. Fixes #33724

The title in tooltips was previously truncated if it exceeded 1000 characters, but this commit changes it to truncate at 200 characters instead. This improves readability and prevents tooltips from becoming too long. Fixes #33724

coderabbitai · 2024-06-26T11:58:17Z

Walkthrough

Recent changes in AutoToolTipComponent.tsx were made to improve user experience when dealing with long texts in table tooltips. A new constant limits tooltip character length, and a modification now truncates excessively long tooltips, ensuring they do not cover too much of the table data and disappear appropriately after a hover.

Changes

File Path	Summary
`app/client/src/widgets/TableWidgetV2/component/cellComponents/...`	Added `useMemo` import from React, introduced `MAX_CHARS_ALLOWED_IN_TOOLTIP` constant, and modified the `useToolTip` function to truncate titles exceeding this limit.

Assessment against linked issues

Objective	Addressed	Explanation
Allow users to have tooltips that do not cover the entire table	✅

Poem

In a table filled with data bright,
Tooltips now won't steal the light.
Text too long? They all align,
Neatly trimmed, they now define.
Hover smooth, the data's right,
A fix that makes the view delight.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

rahulbarwal · 2024-06-26T11:58:57Z

/build-deploy-preview skip-tests=true

github-actions · 2024-06-26T11:59:19Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9679182549.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34507.
recreate: .

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6a761d6 and f62f0c4.

Files selected for processing (1)

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx (4 hunks)

Files not reviewed due to errors (1)

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx (no review received)

github-actions · 2024-06-26T12:13:00Z

Deploy-Preview-URL: https://ce-34507.dp.appsmith.com

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx

… in AutoToolTipComponent

…orrectly

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f62f0c4 and ef06bcc.

Files selected for processing (1)

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx (4 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ef06bcc and 514e8f4.

Files selected for processing (1)

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx (5 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx

…o fix-23156/truncate-tooltip-content-on-table

…cters (appsmithorg#34507) ## Description Truncate the title in tooltips if it exceeds 1000 characters to improve readability. Fixes appsmithorg#23156 _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Widget" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9697818492> > Commit: a4007cb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9697818492&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Widget`  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Improved tooltip functionality to automatically truncate text that exceeds a set character limit, enhancing readability.

rahulbarwal added 2 commits June 26, 2024 16:08

chore: Add title truncation for tooltips

e2db9f7

Truncate the title in tooltips if it exceeds 1000 characters to improve readability. Fixes #33724

rahulbarwal added the Widgets & Blocks Pod label Jun 26, 2024

rahulbarwal self-assigned this Jun 26, 2024

rahulbarwal requested a review from jacquesikot June 26, 2024 11:58

rahulbarwal added the ok-to-test Required label for CI label Jun 26, 2024

coderabbitai bot reviewed Jun 26, 2024

View reviewed changes

rahulbarwal added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jun 27, 2024

rahulbarwal mentioned this pull request Jun 27, 2024

fix: Update AutoToolTipComponent to use right position #34479

Closed

2 tasks

rahulbarwal requested a review from ashit-rath June 27, 2024 09:55

ashit-rath reviewed Jun 27, 2024

View reviewed changes

app/client/src/widgets/TableWidgetV2/component/cellComponents/AutoToolTipComponent.tsx Outdated Show resolved Hide resolved

rahulbarwal requested a review from ashit-rath June 27, 2024 11:50

rahulbarwal added 3 commits June 27, 2024 17:38

Refactor tooltip content truncation logic in AutoToolTipComponent

17682dc

Refactor: Remove unused tableWidth parameter from useToolTip function…

ef06bcc

… in AutoToolTipComponent

Fix tooltip truncation logic in TableWidgetV2 to handle long titles c…

514e8f4

…orrectly

rahulbarwal added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jun 27, 2024

coderabbitai bot reviewed Jun 27, 2024

View reviewed changes

ashit-rath approved these changes Jun 27, 2024

View reviewed changes

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

a4007cb

…o fix-23156/truncate-tooltip-content-on-table

rahulbarwal added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Jun 27, 2024

rahulbarwal merged commit b693377 into release Jun 27, 2024

rahulbarwal deleted the fix-23156/truncate-tooltip-content-on-table branch June 27, 2024 15:22

rahulbarwal mentioned this pull request Jul 31, 2024

[Bug]: Popover not closing for large text for table widget #20213

Closed

1 task

coderabbitai bot mentioned this pull request Oct 21, 2024

fix:- added elipsis and tooltip to the button content in table widget component #36865

Merged

coderabbitai bot mentioned this pull request Nov 1, 2024

fix: Enhance URL handling in table by rendering URL column types with <a> tag. #37179

Merged

2 tasks

coderabbitai bot mentioned this pull request Nov 20, 2024

feat:[POC] HTML column type support in table #37603

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Truncate title in tooltips in table cell if it exceeds 200 characters#34507

fix: Truncate title in tooltips in table cell if it exceeds 200 characters#34507
rahulbarwal merged 6 commits intoreleasefrom
fix-23156/truncate-tooltip-content-on-table

rahulbarwal commented Jun 26, 2024 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Jun 26, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

rahulbarwal commented Jun 26, 2024

Uh oh!

github-actions bot commented Jun 26, 2024

Uh oh!

coderabbitai bot left a comment

Uh oh!

github-actions bot commented Jun 26, 2024

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

rahulbarwal commented Jun 26, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Assessment against linked issues

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

rahulbarwal commented Jun 26, 2024

Uh oh!

github-actions bot commented Jun 26, 2024

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 26, 2024

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rahulbarwal commented Jun 26, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Jun 26, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)