Skip to content

chore: Remove redundant adding Postgres bin to PATH#34316

Merged
sharat87 merged 1 commit intoreleasefrom
sharat87-patch-3
Jun 20, 2024
Merged

chore: Remove redundant adding Postgres bin to PATH#34316
sharat87 merged 1 commit intoreleasefrom
sharat87-patch-3

Conversation

@sharat87
Copy link
Member

@sharat87 sharat87 commented Jun 19, 2024

This temporary change is no longer needed.

/test sanity

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9574310795
Commit: abad77f
Cypress dashboard.
Tags: @tag.Sanity

Summary by CodeRabbit

  • Chores
    • Improved the startup script by removing obsolete PATH modification for PostgreSQL.

@sharat87 sharat87 added the ok-to-test Required label for CI label Jun 19, 2024
@sharat87 sharat87 enabled auto-merge (squash) June 19, 2024 00:51
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 19, 2024
@sharat87 sharat87 disabled auto-merge June 19, 2024 00:52
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 19, 2024

Walkthrough

The recent change focuses on cleaning up the entrypoint.sh script in the Docker deployment setup for Appsmith. Specifically, it removes an unnecessary modification of the PATH environment variable that was previously pointing to the PostgreSQL binaries. This simplification ensures that the script no longer temporarily alters the environment variable for PostgreSQL.

Changes

File Path Change Summary
deploy/docker/fs/opt/appsmith/entrypoint.sh Removed temporary PATH modification related to PostgreSQL.

Poem

Amid the code, a rabbit sees,
No paths to change, just ease and breeze.
With Postgre’s bin now out of sight,
The script runs pure, oh what delight!

🐰✨ In Docker’s realm, simplicity gleams,
Chasing bugs to peaceful dreams. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (2)
deploy/docker/fs/opt/appsmith/entrypoint.sh (2)

Line range hint 62-62: Separate declaration and assignment of variables to avoid masking return values.

- local no_proxy_lines="$(echo "$NO_PROXY" | tr , \\n)"
+ local no_proxy_lines
+ no_proxy_lines="$(echo "$NO_PROXY" | tr , \\n)"

Apply similar changes to other lines flagged by ShellCheck.

Also applies to: 66-66, 70-70, 74-74


Line range hint 86-86: Handle dynamic sourcing more robustly to avoid potential execution errors.

- . "$ENV_PATH"
+ if [[ -f "$ENV_PATH" ]]; then
+   . "$ENV_PATH"
+ else
+   echo "Environment path $ENV_PATH does not exist."
+ fi
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f718bfb and abad77f.

Files selected for processing (1)
  • deploy/docker/fs/opt/appsmith/entrypoint.sh (1 hunks)
Additional context used
Shellcheck
deploy/docker/fs/opt/appsmith/entrypoint.sh

[warning] 62-62: Declare and assign separately to avoid masking return values. (SC2155)


[warning] 66-66: Declare and assign separately to avoid masking return values. (SC2155)


[warning] 70-70: Declare and assign separately to avoid masking return values. (SC2155)


[warning] 74-74: Declare and assign separately to avoid masking return values. (SC2155)


[warning] 86-86: ShellCheck can't follow non-constant source. Use a directive to specify location. (SC1090)

@sharat87 sharat87 enabled auto-merge (squash) June 19, 2024 01:32
@sharat87 sharat87 requested a review from mohanarpit June 19, 2024 01:33
@sharat87 sharat87 merged commit e38c7cc into release Jun 20, 2024
@sharat87 sharat87 deleted the sharat87-patch-3 branch June 20, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants