chore: Remove redundant adding Postgres bin to PATH#34316
Conversation
WalkthroughThe recent change focuses on cleaning up the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (2)
deploy/docker/fs/opt/appsmith/entrypoint.sh (2)
Line range hint
62-62: Separate declaration and assignment of variables to avoid masking return values.- local no_proxy_lines="$(echo "$NO_PROXY" | tr , \\n)" + local no_proxy_lines + no_proxy_lines="$(echo "$NO_PROXY" | tr , \\n)"Apply similar changes to other lines flagged by ShellCheck.
Also applies to: 66-66, 70-70, 74-74
Line range hint
86-86: Handle dynamic sourcing more robustly to avoid potential execution errors.- . "$ENV_PATH" + if [[ -f "$ENV_PATH" ]]; then + . "$ENV_PATH" + else + echo "Environment path $ENV_PATH does not exist." + fi
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- deploy/docker/fs/opt/appsmith/entrypoint.sh (1 hunks)
Additional context used
Shellcheck
deploy/docker/fs/opt/appsmith/entrypoint.sh
[warning] 62-62: Declare and assign separately to avoid masking return values. (SC2155)
[warning] 66-66: Declare and assign separately to avoid masking return values. (SC2155)
[warning] 70-70: Declare and assign separately to avoid masking return values. (SC2155)
[warning] 74-74: Declare and assign separately to avoid masking return values. (SC2155)
[warning] 86-86: ShellCheck can't follow non-constant source. Use a directive to specify location. (SC1090)
This temporary change is no longer needed.
/test sanity
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9574310795
Commit: abad77f
Cypress dashboard.
Tags:
@tag.SanitySummary by CodeRabbit