chore: Deprecate `.findById` signature with `Optional` parameter by sharat87 · Pull Request #34281 · appsmithorg/appsmith

sharat87 · 2024-06-17T11:54:22Z

This is work on getting to remove the .findById signature with Optional<> arguments. This signature doesn't add any value, encourages confusing multi-signature service methods (check the diff here), and is causing unnecessary problems in pg branch with generating *Cake classes.

This PR doesn't get rid of this entirely, just one part. A follow-up PR will be opened after this is merged.

Nothing new, nothing fixed. Only a refactor.

No conflicts to EE, but needs extra changes, in this PR to be merged for the build to pass.

/test sanity

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9549476417
Commit: c1e45f2
Cypress dashboard.
Tags: @tag.Sanity

Summary by CodeRabbit

Refactor
- Simplified method signatures by removing the use of Optional for permission parameters across various services. Permissions are now passed directly.
- Deprecated findById method that uses Optional<AclPermission> to improve code clarity and maintainability.
Chores
- Updated test cases to remove the use of Optional.empty() and replaced with null in method calls.
- Removed unnecessary imports of Optional in multiple files.

coderabbitai · 2024-06-17T11:54:28Z

Walkthrough

The primary objective of these changes was to eliminate the use of Optional for handling permissions throughout the codebase. The methods that previously accepted Optional<AclPermission> now expect AclPermission directly. Additionally, Optional.empty() arguments have been replaced with null, and related import statements have been removed. These updates simplify the method signatures and streamline the application logic for better readability and maintainability.

Changes

Files/Paths	Change Summary
`ActionCollectionServiceCE.java`, `ActionCollectionServiceCEImpl.java`	Modified methods to take `AclPermission` directly instead of `Optional<AclPermission>`.
`GitApplicationHelperCEImpl.java`, `PartialImportServiceCEImpl.java`, `CurlImporterServiceCEImpl.java`	Replaced `Optional.empty()` with `null` in method calls to `findById`.
`NewActionServiceCE.java`, `NewActionServiceCEImpl.java`, `NewActionImportableServiceCEImpl.java`	Methods updated to take `AclPermission` directly and removed `Optional` parameters.
`NewPageServiceCE.java`, `NewPageServiceCEImpl.java`, `NewPageImportableServiceCEImpl.java`	Methods updated to take `AclPermission` directly, removed import `Optional`, and renamed methods for consistency.
`AppsmithRepository.java`, `BaseAppsmithRepositoryCEImpl.java`	Added `@Deprecated` annotation to methods using `Optional` for permission parameters.
`ApplicationPageServiceCE.java`, `ApplicationPageServiceCEImpl.java`	Updated method signatures to replace `Optional<AclPermission>` with `AclPermission` directly.
`ActionCollectionServiceImplTest.java`, `NewPageServiceTest.java`, `PartialImportServiceTest.java`	Updated test methods to use direct `AclPermission` parameters and replaced `Optional.empty()` with `null` in method calls.

Poem

In fields of green, code rabbits play,
Simplifying paths, in an elegant way.
No more "Optional" clutter in view,
Permissions clear, concise, and true.
With every change, efficiency we cheer,
Code refined, bunnies hold dear.
In software's garden, a brighter day,
Hopping swiftly, we pave the way. 🌿🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-06-17T12:20:24Z

Failed server tests

com.appsmith.server.fork.ForkingServiceTest#cloneApplication_whenDslParsingFails_shouldSucceed
com.appsmith.server.services.ActionCollectionServiceImplTest#testDeleteUnpublishedActionCollection_withInvalidId_throwsError
com.appsmith.server.services.ActionCollectionServiceImplTest#testDeleteUnpublishedActionCollection_withPublishedCollectionAndActions_returnsActionCollectionDTO
com.appsmith.server.services.ActionCollectionServiceImplTest#testDeleteUnpublishedActionCollection_withPublishedCollectionAndNoActions_returnsActionCollectionDTO
com.appsmith.server.services.ActionCollectionServiceImplTest#testDeleteUnpublishedActionCollection_withoutPublishedCollectionAndNoActions_returnsActionCollectionDTO
com.appsmith.server.services.ActionCollectionServiceImplTest#testDeleteUnpublishedActionCollection_withoutPublishedCollectionAndWithActions_returnsActionCollectionDTO

coderabbitai

Actionable comments posted: 6

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between a638c47 and c1e45f2.

Files selected for processing (18)

app/server/appsmith-server/src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCE.java (2 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCEImpl.java (3 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/applications/git/GitApplicationHelperCEImpl.java (1 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/imports/internal/partial/PartialImportServiceCEImpl.java (2 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/base/NewActionServiceCE.java (2 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/base/NewActionServiceCEImpl.java (3 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/importable/NewActionImportableServiceCEImpl.java (2 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/newpages/base/NewPageServiceCE.java (2 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/newpages/base/NewPageServiceCEImpl.java (2 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/newpages/importable/NewPageImportableServiceCEImpl.java (1 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/AppsmithRepository.java (1 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java (1 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCE.java (2 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java (4 hunks)
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java (2 hunks)
app/server/appsmith-server/src/test/java/com/appsmith/server/services/ActionCollectionServiceImplTest.java (6 hunks)
app/server/appsmith-server/src/test/java/com/appsmith/server/services/NewPageServiceTest.java (4 hunks)
app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/PartialImportServiceTest.java (3 hunks)

Files not reviewed due to errors (1)

app/server/appsmith-server/src/test/java/com/appsmith/server/services/ActionCollectionServiceImplTest.java (no review received)

Files skipped from review due to trivial changes (2)

app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/CurlImporterServiceCEImpl.java

Additional context used

Learnings (9)

Common learnings

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/AppsmithRepository.java (2)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/AppsmithRepository.java:29-29
Timestamp: 2024-06-03T11:52:27.242Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts.

app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCE.java (1)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

app/server/appsmith-server/src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCE.java (1)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/base/NewActionServiceCE.java (1)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

app/server/appsmith-server/src/test/java/com/appsmith/server/services/ActionCollectionServiceImplTest.java (2)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/AppsmithRepository.java:29-29
Timestamp: 2024-06-03T11:52:27.242Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts.

app/server/appsmith-server/src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCEImpl.java (1)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java (1)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/base/NewActionServiceCEImpl.java (1)

User: sharat87
PR: appsmithorg/appsmith#33602
File: app/server/appsmith-server/src/main/java/com/appsmith/server/repositories/ce/BaseAppsmithRepositoryCEImpl.java:462-473
Timestamp: 2024-06-03T11:56:24.442Z
Learning: The codebase has mechanisms to gracefully handle `null` values, making the use of `Optional` for `AclPermission` unnecessary in certain contexts. This is leveraged by replacing `Optional.empty()` with `null` in method signatures where `null` is already handled gracefully.

Additional comments not posted (14)

app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCE.java (1)

52-57: The updated signature of deleteUnpublishedPage correctly replaces Optional parameters with AclPermission. Ensure all calls to this method are updated to reflect this change.

app/server/appsmith-server/src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCE.java (1)

49-50: The updated signature of deleteUnpublishedActionCollection correctly replaces Optional parameters with AclPermission. Ensure all calls to this method are updated to reflect this change.

app/server/appsmith-server/src/main/java/com/appsmith/server/newpages/base/NewPageServiceCE.java (1)

74-74: The addition of archiveByIdWithoutPermission provides flexibility in handling permissions. Ensure this method is used appropriately in contexts where permission checks are not required.

app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/base/NewActionServiceCE.java (2)

51-51: The method signature change from Optional<AclPermission> to AclPermission aligns with the PR's objectives to simplify method signatures and avoid unnecessary use of Optional. Good job on enhancing clarity.

87-87: Replacing Optional<AclPermission> with AclPermission in the method signature of deleteUnpublishedAction is a positive change, enhancing the method's clarity and consistency with other service methods.

app/server/appsmith-server/src/main/java/com/appsmith/server/applications/git/GitApplicationHelperCEImpl.java (1)

259-259: Replacing Optional.empty() with null in the findById method call simplifies the interface and leverages the codebase's existing null handling mechanisms. This change aligns well with the PR's objectives.

app/server/appsmith-server/src/test/java/com/appsmith/server/solutions/PartialImportServiceTest.java (1)

285-285: The replacement of Optional.empty() with null in the findById method calls across multiple test methods improves consistency and aligns with the PR's objectives to simplify method signatures.

Also applies to: 403-403, 484-484

app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/importable/NewActionImportableServiceCEImpl.java (1)

101-101: Refactoring to remove Optional parameters is well executed here by directly passing null where Optional.empty() was previously used.

app/server/appsmith-server/src/main/java/com/appsmith/server/newpages/base/NewPageServiceCEImpl.java (1)

519-519: The refactoring to remove Optional parameters from the archiveByIdWithoutPermission and archiveById methods aligns with the PR's objectives. This simplifies the method signatures and avoids potential confusion.

Also applies to: 525-525, 533-533

app/server/appsmith-server/src/main/java/com/appsmith/server/imports/internal/partial/PartialImportServiceCEImpl.java (1)

377-377: The change from Optional to null aligns with the PR's objectives to simplify method signatures and the codebase's capability to handle null values effectively.

app/server/appsmith-server/src/main/java/com/appsmith/server/newpages/importable/NewPageImportableServiceCEImpl.java (1)

362-365: The method deleteUnpublishedPage has been modified to use direct null values instead of Optional.empty(). This aligns with the PR's objective to simplify method signatures by removing Optional parameters. However, ensure that the method deleteUnpublishedPage and archiveByIdWithoutPermission are robust against null values to prevent potential NullPointerExceptions.
app/server/appsmith-server/src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCEImpl.java (2)
Line range hint 355-369: The method deleteUnpublishedActionCollection is well-structured with clear error handling and logging. The integration of permission checks and analytics is effective, supporting the overall functionality of the method.

345-345: The method deleteWithoutPermissionUnpublishedActionCollection now correctly delegates to deleteUnpublishedActionCollection with a null for permissions, aligning with the PR's objective to simplify signatures.

Verification successful

We need to verify the reference to deleteWithoutPermissionUnpublishedActionCollection in NewActionImportableServiceCEImpl.java and ensure that the method declaration in ActionCollectionServiceCE.java matches the new signature. Let's examine the relevant code in these files to confirm the compatibility.

The verification confirms that the method deleteWithoutPermissionUnpublishedActionCollection in NewActionImportableServiceCEImpl.java correctly uses the new signature. Additionally, the method declaration in ActionCollectionServiceCE.java matches the new signature.

NewActionImportableServiceCEImpl.java: The method call to deleteWithoutPermissionUnpublishedActionCollection correctly passes a single collectionId argument.

ActionCollectionServiceCE.java: The interface declaration for deleteWithoutPermissionUnpublishedActionCollection matches the new signature.
Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# Description: Verify all calls to `deleteWithoutPermissionUnpublishedActionCollection` handle the new signature correctly.

# Test: Search for the function usage. Expect: Only occurances of the new signature.
rg --type java $'deleteWithoutPermissionUnpublishedActionCollection'
Length of output: 722

Script:
#!/bin/bash
# Verify the reference in NewActionImportableServiceCEImpl.java
rg --context 5 --type java $'deleteWithoutPermissionUnpublishedActionCollection' app/server/appsmith-server/src/main/java/com/appsmith/server/newactions/importable/NewActionImportableServiceCEImpl.java

# Verify the method declaration in ActionCollectionServiceCE.java
rg --context 5 --type java $'deleteWithoutPermissionUnpublishedActionCollection' app/server/appsmith-server/src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCE.java
Length of output: 1779
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/ApplicationPageServiceCEImpl.java (1)

910-915: Refactor to remove Optional parameters in method signatures aligns with PR objectives.

This change simplifies the method signature by directly using AclPermission instead of Optional<AclPermission>, reducing unnecessary complexity and aligning with Java best practices for handling permissions.

Also applies to: 936-939

app/server/appsmith-server/src/test/java/com/appsmith/server/services/NewPageServiceTest.java

...ppsmith-server/src/main/java/com/appsmith/server/newactions/base/NewActionServiceCEImpl.java

...erver/appsmith-server/src/main/java/com/appsmith/server/repositories/AppsmithRepository.java

.../src/main/java/com/appsmith/server/actioncollections/base/ActionCollectionServiceCEImpl.java

Follow up to #34281. The `.findById` method is now removed. No conflicts, but needs extra changes in [this PR](appsmithorg/appsmith-ee#4482) for build to pass on EE. **/test sanity**  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9563607766> > Commit: 02f6031 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9563607766&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity`   ## Summary by CodeRabbit - **Refactor** - Updated methods to use direct values instead of `Optional` for permissions, simplifying method signatures and improving readability.

Deprecate .findById signature with Optional parameter

d2edf14

sharat87 changed the title ~~Deprecate .findById signature with Optional parameter~~ chore: Deprecate .findById signature with Optional parameter Jun 17, 2024

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jun 17, 2024

fix tests

be4c02e

sharat87 changed the title ~~chore: Deprecate .findById signature with Optional parameter~~ chore: Deprecate .findById signature with Optional parameter Jun 17, 2024

Merge branch 'release' into chore/no-optional

c1e45f2

sharat87 added the ok-to-test Required label for CI label Jun 17, 2024

sharat87 marked this pull request as ready for review June 18, 2024 02:08

sharat87 requested review from a team, nidhi-nair and sondermanish as code owners June 18, 2024 02:08

sharat87 requested review from AnaghHegde, mohanarpit and trishaanand June 18, 2024 02:08

coderabbitai bot reviewed Jun 18, 2024

View reviewed changes

trishaanand approved these changes Jun 18, 2024

View reviewed changes

sharat87 merged commit 4bc1785 into release Jun 18, 2024

sharat87 deleted the chore/no-optional branch June 18, 2024 09:37

sharat87 mentioned this pull request Jun 18, 2024

chore: Remove findById signature with Optional #34302

Merged

coderabbitai bot mentioned this pull request Oct 22, 2024

chore: Add spans attributes for no of lines and action count #37001

Merged

2 tasks

coderabbitai bot mentioned this pull request Nov 14, 2024

chore: Remove unused UserData.role #37381

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Deprecate `.findById` signature with `Optional` parameter#34281

chore: Deprecate `.findById` signature with `Optional` parameter#34281
sharat87 merged 3 commits intoreleasefrom
chore/no-optional

sharat87 commented Jun 17, 2024 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 17, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jun 17, 2024

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

sharat87 commented Jun 17, 2024 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jun 17, 2024

Failed server tests

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sharat87 commented Jun 17, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 17, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)