Skip to content

chore: fix validation in wds phoneinput widget #34177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsartisan merged 1 commit into from
Jun 12, 2024
Merged

chore: fix validation in wds phoneinput widget #34177

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/src/widgets/wds/WDSPhoneInputWidget/widget/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type { ISDCodeProps } from "constants/ISDCodes_v2";
import { ISDCodeOptions } from "constants/ISDCodes_v2";

export function validateInput(props: any) {
const value = props.text ?? "";
const value = props.parsedText ?? "";
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the typo in the return object's property name.

- validattionStatus: isInvalid ? "invalid" : undefined,
+ validationStatus: isInvalid ? "invalid" : undefined,
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const value = props.parsedText ?? "";
const value = props.parsedText ?? "";
// Other code in the function
return {
validationStatus: isInvalid ? "invalid" : undefined,
// Other properties in the return object
};

const isInvalid = "isValid" in props && !props.isValid && !!props.isDirty;

const conditionalProps: any = {};
Expand Down