test: flay table header validation#34080
Conversation
WalkthroughThe recent changes focus on improving the Cypress test suite and updating the Table widget's selector. Specifically, the test paths have been revised to include new files for Community Issues and TableV2 widget testing. Additionally, the Table widget's header selector has been simplified from a complex XPath to a more straightforward CSS selector. Changes
Sequence Diagram(s) (Beta)sequenceDiagram
participant User
participant Cypress
participant App
User->>Cypress: Run CommunityIssues_Spec.ts
Cypress->>App: Execute tests for Community Issues
App-->>Cypress: Return test results
User->>Cypress: Run table_data_change_spec.ts
Cypress->>App: Execute tests for TableV2 data change
App-->>Cypress: Return test results
User->>App: Interact with Table widget
App->>App: Use CSS selector for _tableHeader
App-->>User: Display updated table header
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
skip-changelog
|
/ci-test-limit |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- app/client/cypress/limited-tests.txt (1 hunks)
- app/client/cypress/support/Pages/Table.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- app/client/cypress/support/Pages/Table.ts
Additional context used
LanguageTool
app/client/cypress/limited-tests.txt
[uncategorized] ~1-~1: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ... limited tests - give the spec names in below format: cypress/e2e/Regression/Apps/Com...
[uncategorized] ~9-~9: You might be missing the article “the” here. (AI_EN_LECTOR_MISSING_DETERMINER_THE)
Context: ...ile to run minimum of specs. Do not run entire suite with this command.
Additional comments not posted (1)
app/client/cypress/limited-tests.txt (1)
2-4: Updated test paths reflect the new structure and focus areas in the test suite.
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9415371105. |
3 participants
Xpath used to read the header text is flaky.
Solution:
Replacing xpath with css locator to make it stable
EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4382
Summary by CodeRabbit
Tests
Refactor