Skip to content

test: Failing cypress tests due to removal of empty canvas prompts #34037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulbarwal merged 5 commits into from
Jun 7, 2024
Merged

test: Failing cypress tests due to removal of empty canvas prompts #34037

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1a171e
Refactor visual regression tests to use PageList for page generation;…
rahulbarwal Jun 6, 2024
d5e800b
fix: update page creation message in visual tests to use constants
rahulbarwal Jun 6, 2024
48ab152
Merge branch 'release' into fix/failing-specs-due-to-removal-of-empty…
ApekshaBhosale Jun 6, 2024
841712a
Merge branch 'release' of https://github.com/appsmithorg/appsmith int…
rahulbarwal Jun 7, 2024
b6d7f60
Updates page title message source in AppPageLayout_spec.js
rahulbarwal Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions app/client/cypress/e2e/Regression/ClientSide/OtherUIFeatures/EmptyCanvas_spec.js
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion app/client/cypress/e2e/Regression/ClientSide/VisualTests/AppPageLayout_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import {
createMessage,
GENERATE_PAGE_ACTION_TITLE,
} from "../../../../../src/ce/constants/messages";
import homePage from "../../../../locators/HomePage";
import * as _ from "../../../../support/Objects/ObjectsCore";
import PageList from "../../../../support/Pages/PageList";

describe("Visual regression tests", { tags: ["@tag.Visual"] }, () => {
// for any changes in UI, update the screenshot in snapshot folder, to do so:
Expand All @@ -18,7 +23,7 @@ describe("Visual regression tests", { tags: ["@tag.Visual"] }, () => {
cy.get("#root").matchImageSnapshot("apppage");

//Layout validation for Quick page wizard
cy.get("[data-testid='generate-app']").click();
PageList.AddNewPage(createMessage(GENERATE_PAGE_ACTION_TITLE));
Comment thread
ApekshaBhosale marked this conversation as resolved.
Outdated
cy.wait(2000);
// taking screenshot of generate crud page
cy.get("#root").matchImageSnapshot("quickPageWizard");
Expand Down
1 change: 0 additions & 1 deletion app/client/cypress/locators/GeneratePage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"generateCRUDPageActionCard": "[data-testid='generate-app']",
"selectDatasourceDropdown": "[data-testid=t--datasource-dropdown]",
"datasourceDropdownOption": "[data-testid=t--datasource-dropdown-option]",
"selectTableDropdown": "[data-testid=t--table-dropdown]",
Expand Down
1 change: 0 additions & 1 deletion app/client/cypress/support/Pages/HomePage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ export class HomePage {
_applicationName = ".t--application-name";
private _editAppName = "bp3-editable-text-editing";
private _appMenu = ".ads-v2-menu__menu-item-children";
_buildFromDataTableActionCard = "[data-testid='generate-app']";
private _selectRole = "//span[text()='Select a role']/ancestor::div";
private _searchInput = "input[type='text']";
_appHoverIcon = (action: string) => ".t--application-" + action + "-link";
Expand Down