Skip to content

chore: Prefetch module apis in service worker #34003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvj1988 merged 16 commits into from
Jun 14, 2024
Merged

chore: Prefetch module apis in service worker #34003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
876c606
Convert service worker to ts
Jun 5, 2024
59e2a3c
Update ee import path
Jun 5, 2024
200295e
Export TApplicationParams from ce
Jun 6, 2024
d65d297
Change service worker source path
Jun 6, 2024
5af3a7b
EE changes in service worker utils
Jun 6, 2024
88901d0
rm jest test cases
Jun 6, 2024
631ee97
Remove imports from constants/routes/appRoutes
Jun 7, 2024
3b045f0
Remove ee code
Jun 7, 2024
700da97
Refactor
Jun 7, 2024
787bc5a
Add jest test cases
Jun 8, 2024
ddd578e
Get consolidated api base url from ConsolidatedPageLoadApi class
Jun 8, 2024
fda023a
PR review comments
Jun 10, 2024
5619d00
Change the comment
Jun 10, 2024
4b25d98
Update test cases
Jun 11, 2024
c23df88
Remove import from consolidated api
Jun 12, 2024
785197e
Merge remote-tracking branch 'origin' into chore/pre-fetch-modules-api
Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/client/craco.build.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const plugins = [];

plugins.push(
new WorkboxPlugin.InjectManifest({
swSrc: "./src/serviceWorker.js",
swSrc: "./src/serviceWorker.ts",
mode: "development",
swDest: "./pageService.js",
maximumFileSizeToCacheInBytes: 11 * 1024 * 1024,
Expand Down
2 changes: 1 addition & 1 deletion app/client/craco.dev.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = merge(common, {
webpack: {
plugins: [
new WorkboxPlugin.InjectManifest({
swSrc: "./src/serviceWorker.js",
swSrc: "./src/serviceWorker.ts",
mode: "development",
swDest: "./pageService.js",
exclude: [
Expand Down
1 change: 1 addition & 0 deletions app/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@
"@types/moment-timezone": "^0.5.10",
"@types/nanoid": "^2.0.0",
"@types/node": "^10.12.18",
"@types/node-fetch": "^2.6.11",
"@types/node-forge": "^0.10.0",
"@types/object-hash": "^2.2.1",
"@types/pg": "^8.10.2",
Expand Down
8 changes: 5 additions & 3 deletions app/client/src/api/ConsolidatedPageLoadApi.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,21 @@ import type { ApiResponse } from "api/ApiResponses";
import type { InitConsolidatedApi } from "sagas/InitSagas";

class ConsolidatedPageLoadApi extends Api {
static url = "/v1/consolidated-api";
static url = "v1/consolidated-api";
static consolidatedApiViewUrl = `${ConsolidatedPageLoadApi.url}/view`;
static consolidatedApiEditUrl = `${ConsolidatedPageLoadApi.url}/edit`;

static async getConsolidatedPageLoadDataView(params: {
applicationId?: string;
defaultPageId?: string;
}): Promise<AxiosPromise<ApiResponse<InitConsolidatedApi>>> {
return Api.get(ConsolidatedPageLoadApi.url + "/view", params);
return Api.get(ConsolidatedPageLoadApi.consolidatedApiViewUrl, params);
}
static async getConsolidatedPageLoadDataEdit(params: {
applicationId?: string;
defaultPageId?: string;
}): Promise<AxiosPromise<ApiResponse<InitConsolidatedApi>>> {
return Api.get(ConsolidatedPageLoadApi.url + "/edit", params);
return Api.get(ConsolidatedPageLoadApi.consolidatedApiEditUrl, params);
}
}

Expand Down
Loading