Skip to content

chore: Fix extra space at the end of multi-line input widget #33099 #33886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsartisan merged 4 commits into from
Jun 3, 2024
Merged

chore: Fix extra space at the end of multi-line input widget #33099 #33886

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddd5571
add a hacky solution to fix textarea height
May 31, 2024
e7c5ab1
use margin instead of padding
May 31, 2024
67b5563
subtract the padding
May 31, 2024
5f1ea63
fix textarea height
May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions app/client/packages/design-system/headless/src/components/TextArea/src/TextArea.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,17 @@ function TextArea(props: TextAreaProps, ref: TextAreaRef) {
}
input.style.alignSelf = "start";
input.style.height = "auto";
// offsetHeight - clientHeight accounts for the border/padding.

const computedStyle = getComputedStyle(input);
const paddingTop = parseFloat(computedStyle.paddingTop);
const paddingBottom = parseFloat(computedStyle.paddingBottom);
input.style.height = `${
input.scrollHeight + (input.offsetHeight - input.clientHeight)
// subtract comptued padding and border to get the actual content height
input.scrollHeight -
paddingTop -
paddingBottom +
// Also, adding 1px to fix a bug in browser where there is a scrolllbar on certain heights
1
Copy link
Contributor Author

@jsartisan jsartisan May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without +1, I see this bug

CleanShot.2024-05-31.at.16.34.35.mp4

@KelvinOm

Copy link
Collaborator

@KelvinOm KelvinOm Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsartisan This works without adding 1. Please check it. It looks like the calculations were simply wrong before.

Copy link
Contributor Author

@jsartisan jsartisan Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, without 1, it does not work.
I have these settings on my mac.
CleanShot 2024-06-03 at 15 23 18@2x

Copy link
Collaborator

@KelvinOm KelvinOm Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

}px`;
input.style.overflow = prevOverflow;
input.style.alignSelf = prevAlignment;
Expand Down